Find extra people from the PentaDb during the hydration step (#179)

Author: reivilibre

src/__tests__/backends/penta/CachingBackend.test.ts

@@ -66,6 +66,7 @@ test("the cache should restore the same talks that were saved", async () => {
                 role: Role.Speaker
             }
         ]),
+        findAllPeopleForTalk: jest.fn(PentaDb.prototype.findAllPeopleForTalk).mockResolvedValue([]),
     } as any as PentaDb;
 
     async function newPentaBackend(): Promise<PentaBackend> {

src/__tests__/backends/penta/PentaBackend.test.ts

@@ -62,6 +62,7 @@ test("talks should be rehydrated from the database", async () => {
                 role: Role.Speaker
             }
         ]),
+        findAllPeopleForTalk: jest.fn(PentaDb.prototype.findAllPeopleForTalk).mockResolvedValue([]),
     } as any as PentaDb;
 
     const b = new PentaBackend(backendConfig, parser, fakeDb);

src/backends/penta/PentaBackend.ts

@@ -71,6 +71,17 @@ export class PentaBackend implements IScheduleBackend {
         const dbTalk = await this.db.getTalk(talk.id);
         if (dbTalk === null) return;
         this.rehydrateTalkFrom(talk, dbTalk);
+
+        // Not all people are listed in the Penta XML!
+        // Notably, devroom managers ('coordinators') are only available in the database.
+        // Make sure we get those whilst we hydrate our talk...
+        for (const person of await this.db.findAllPeopleForTalk(talk.id)) {
+            // Ensure we don't wind up duplicating people; this step is purely to get people who were missed out of the XML.
+            if (!talk.speakers.find(s => s.id == person.id)) {
+                // The person is already hydrated — they're straight from the DB — so no hydration step needed here.
+                talk.speakers.push(person);
+            }
+        }
     }
 
     private rehydrateTalkFrom(talk: ITalk, dbTalk: IDbTalk): void {

src/models/schedule.ts

@@ -56,6 +56,10 @@ export interface ITalk {
     title: string;
     subtitle: string;
     track: string;
+    /**
+     * MISNOMER: This variable contains ALL people for the talk, NOT JUST speakers.
+     * TODO rename (at a time when it's a less risky change to do...)
+     */
     speakers: IPerson[];
     prerecorded: boolean;
     /**