Skip to content

Conversation

@kegsay
Copy link
Member

@kegsay kegsay commented Jun 6, 2025

We have this lovely room version abstraction, but... no one can actually use it without getting it into this map. Let's fix that.

@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 52.94118% with 16 lines in your changes missing coverage. Please review.

Project coverage is 59.55%. Comparing base (904c8f0) to head (8255061).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
eventauth.go 44.44% 15 Missing ⚠️
eventcontent.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   59.55%   59.55%   -0.01%     
==========================================
  Files          51       51              
  Lines        7262     7276      +14     
==========================================
+ Hits         4325     4333       +8     
- Misses       2536     2542       +6     
  Partials      401      401              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Else you can't make custom versions..
Copy link
Contributor

@devonh devonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a potential test addition, this looks perfectly reasonable to me.

@kegsay kegsay merged commit a234d6d into main Jul 4, 2025
5 of 7 checks passed
@kegsay kegsay deleted the kegan/extra-room-vers branch July 4, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants