Add sticky event parsing #462
Open
+194
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
==========================================
+ Coverage 53.43% 53.83% +0.40%
==========================================
Files 52 52
Lines 7842 7870 +28
==========================================
+ Hits 4190 4237 +47
+ Misses 3247 3223 -24
- Partials 405 410 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
devonh
reviewed
Oct 23, 2025
Comment on lines
+30
to
+31
| UnstableSticky stickyEventData `json:"msc4354_sticky,omitempty"` | ||
| StableSticky stickyEventData `json:"sticky,omitempty"` |
There was a problem hiding this comment.
Should this be applied to eventV1?
At a glance, I would think this only applies to eventV3 or newer. But I haven't been following gmsl or that MSC so maybe I'm wrong.
There was a problem hiding this comment.
It's not tied to a room version, so v1 probably makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSC: matrix-org/matrix-spec-proposals#4354
This is for policyserv so we can block sticky events in our public rooms (they aren't needed there)