RoomAccessSyncer: Await processing of cached channel modes that changed. (#1620)

* RoomAccessSyncer: Await processing of cached channel modes that changed.

* Rename change logfile

* Rename 1620.bugfix to 1620.misc

---------

Co-authored-by: Christian Paul <[email protected]>
Co-authored-by: Will Hunt <[email protected]>

Author: 3 people

changelog.d/1620.misc

@@ -0,0 +1 @@
+RoomAccessSyncer: Await processing of cached channel modes that changed.

src/bridge/RoomAccessSyncer.ts

@@ -344,10 +344,11 @@ export class RoomAccessSyncer {
         Object.values(roomModeMap).forEach((roomMode) => {
             roomMode.forEach((m) => {oldModes.add(m)});
         });
-        req.log.debug(`Got cached mode for ${channel} ${[...oldModes]}`);
+        const oldModesArray = [...oldModes];
+        req.log.debug(`Got cached mode for ${channel} ${oldModesArray}`);
 
         // For each cached mode we have for the room, that is no longer set: emit a disabled mode.
-        promises.concat([...oldModes].map((oldModeChar) => {
+        promises.push(...oldModesArray.map((oldModeChar) => {
             if (!MODES_TO_WATCH.includes(oldModeChar)) {
                 return Promise.resolve();
             }