Add error messages when checking room

Author: justinbot

src/provisioning/Provisioner.ts

@@ -182,7 +182,7 @@ export class Provisioner extends ProvisioningApi {
             return joinRulesEvent.join_rule === 'public';
         } catch (e) {
             throw new ApiError(
-                "Could not check if Matrix room is public",
+                "Could not check if room is public",
                 ErrCode.Unknown,
             );
         }

widget/src/SlackApp.tsx

@@ -372,13 +372,23 @@ export const SlackApp = () => {
     const getLink = useCallback(async() => {
         try {
             const link = await client.getLink(provisioningContext.roomId);
-            setLink(link ?? null);
+            setLink(link);
         } catch (e) {
-            console.error('Failed to get link:', e);
-            setError(
-                'Could not get link status.'
-                + ` ${e instanceof ProvisioningError ? e.message : ''}`
-            );
+            if (e instanceof ProvisioningError) {
+                if (e.errcode === 'SLACK_UNKNOWN_LINK') {
+                    setLink(null);
+                } else if (e.errcode === 'SLACK_ROOM_NOT_PUBLIC') {
+                    setError('This bridge only allows public Matrix rooms to be linked.');
+                } else if (e.errcode === 'SLACK_NOT_ENOUGH_POWER') {
+                    setError("You don't have permissions to link this room.");
+                } else {
+                    console.error('Failed to get link:', e);
+                    setError(`Could not get link status. ${e.message}`);
+                }
+            } else {
+                console.error('Failed to get link:', e);
+                setError('Could not get link status.');
+            }
         }
     }, [client, provisioningContext]);
 

widget/src/SlackProvisioningClient.ts

@@ -41,22 +41,15 @@ export class SlackProvisioningClient {
         readonly client: ProvisioningClient,
     ) {}
 
-    getLink = async(roomId: string): Promise<GetLinkResponse | undefined> => {
-        try {
-            const res = await this.client.request(
-                'POST',
-                '/getlink',
-                {
-                    matrix_room_id: roomId,
-                },
-            );
-            return res as GetLinkResponse;
-        } catch (e) {
-            if (e instanceof ProvisioningError && e.errcode === 'SLACK_UNKNOWN_LINK') {
-                return undefined;
-            }
-            throw e;
-        }
+    getLink = async(roomId: string): Promise<GetLinkResponse> => {
+        const res = await this.client.request(
+            'POST',
+            '/getlink',
+            {
+                matrix_room_id: roomId,
+            },
+        );
+        return res as GetLinkResponse;
     };
 
     listWorkspaces = async(): Promise<SlackWorkspace[]> => {