Update matrix-appservice-bridge

jaywink · jaywink · commit dfefdee682a3 · 2025-10-21T17:03:19.000+03:00
Update `matrix-appservice-bridge` to fix `IO.ELEMENT.MSC4190.M_APPSERVICE_LOGIN_UNSUPPORTED` error with MSC4190 enabled homeservers.

A few await's needed as either the methods are now async OR we were previously trying to feed promises into strings.
diff --git a/changelog.d/371.bugfix b/changelog.d/371.bugfix
@@ -0,0 +1 @@
+Update `matrix-appservice-bridge` to fix `IO.ELEMENT.MSC4190.M_APPSERVICE_LOGIN_UNSUPPORTED` error with MSC4190 enabled homeservers.
diff --git a/changelog.d/371.misc b/changelog.d/371.misc
@@ -0,0 +1 @@
+Update required Node version to 22.
diff --git a/package.json b/package.json
@@ -39,7 +39,7 @@
     "leven": "^3.0.0",
     "marked": "^11.1.1",
     "nedb": "^1.8.0",
-    "matrix-appservice-bridge": "^10.2.1",
+    "matrix-appservice-bridge": "^11.1.0",
     "pg": "8.11.3",
     "prom-client": "^15.1.0",
     "quick-lru": "^5.0.0"
diff --git a/src/AutoRegistration.ts b/src/AutoRegistration.ts
@@ -200,7 +200,7 @@ export class AutoRegistration {
         try {
             profile = await intent.getProfileInfo(mxId);
             if (profile.avatar_url) {
-                profile.avatar_url = intent.matrixClient.mxcToHttpThumbnail(profile.avatar_url, 128, 128, "crop");
+                profile.avatar_url = await intent.matrixClient.mxcToHttpThumbnail(profile.avatar_url, 128, 128, "crop");
             }
         } catch (ex) {
             // Appservice bots don't usually have profiles.
diff --git a/src/xmppjs/ServiceHandler.ts b/src/xmppjs/ServiceHandler.ts
@@ -313,7 +313,7 @@ export class ServiceHandler {
         if (avatar) {
             return avatar;
         }
-        const thumbUrl = intent.matrixClient.mxcToHttpThumbnail(
+        const thumbUrl = await intent.matrixClient.mxcToHttpThumbnail(
             avatarUrl, 256, 256, "scale"
         );
         if (!thumbUrl) {
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Update `matrix-appservice-bridge` to fix `IO.ELEMENT.MSC4190.M_APPSERVICE_LOGIN_UNSUPPORTED` error with MSC4190 enabled homeservers.
Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ export class AutoRegistration {`
`200`	`200`	`try {`
`201`	`201`	`profile = await intent.getProfileInfo(mxId);`
`202`	`202`	`if (profile.avatar_url) {`
`203`		`- profile.avatar_url = intent.matrixClient.mxcToHttpThumbnail(profile.avatar_url, 128, 128, "crop");`
	`203`	`+ profile.avatar_url = await intent.matrixClient.mxcToHttpThumbnail(profile.avatar_url, 128, 128, "crop");`
`204`	`204`	`}`
`205`	`205`	`} catch (ex) {`
`206`	`206`	`// Appservice bots don't usually have profiles.`
Original file line number	Diff line number	Diff line change
`@@ -313,7 +313,7 @@ export class ServiceHandler {`
`313`	`313`	`if (avatar) {`
`314`	`314`	`return avatar;`
`315`	`315`	`}`
`316`		`- const thumbUrl = intent.matrixClient.mxcToHttpThumbnail(`
	`316`	`+ const thumbUrl = await intent.matrixClient.mxcToHttpThumbnail(`
`317`	`317`	`avatarUrl, 256, 256, "scale"`
`318`	`318`	`);`
`319`	`319`	`if (!thumbUrl) {`