Hotfix fix: waitForEvent does resolve immediatly. (#12201)

* New room header
 - add chat button during call
 - close lobby button in lobby
 - join button if session exists
 - allow to toggle call <-> timeline during call with call button

Compound style for join button in call notify toast.

Signed-off-by: Timo K <[email protected]>

* dont show start call, join button in video rooms.

Signed-off-by: Timo K <[email protected]>

* Make active call check based on participant count
Not based on available call object

Signed-off-by: Timo K <[email protected]>

* fix room header tests

Signed-off-by: Timo K <[email protected]>

* fix room header tests

Signed-off-by: Timo K <[email protected]>

* remove chat button test for displaying.
Chat button display logic is now part of the RoomHeader.

Signed-off-by: Timo K <[email protected]>

* remove duplicate notification Tread icon

Signed-off-by: Timo K <[email protected]>

* remove obsolete jest snapshot

Signed-off-by: Timo K <[email protected]>

* Update src/components/views/rooms/RoomHeader.tsx

Co-authored-by: Robin <[email protected]>

* update isECWidget logic

Signed-off-by: Timo K <[email protected]>

* remove dead code

Signed-off-by: Timo K <[email protected]>

* refactor call options
Add menu to choose if there are multiple options

Signed-off-by: Timo K <[email protected]>

* join ec when clicking join button (dont start jitsi)
Use icon buttons
don't show call icon when join button is visible

Signed-off-by: Timo K <[email protected]>

* refactor isViewingCall

Signed-off-by: Timo K <[email protected]>

* fix room header tests

Signed-off-by: Timo K <[email protected]>

* fix header snapshot

Signed-off-by: Timo K <[email protected]>

* sonar proposals

Signed-off-by: Timo K <[email protected]>

* fix event shiftKey may be undefined

Signed-off-by: Timo K <[email protected]>

* more lobby time before timeout
only await sticky promise on becoming sticky.

Signed-off-by: Timo K <[email protected]>

* don't allow starting new calls if there is an ongoing other call.

Signed-off-by: Timo K <[email protected]>

* review

Signed-off-by: Timo K <[email protected]>

* fix translation typo

Signed-off-by: Timo K <[email protected]>

* missing await in case customTimeout=false

Signed-off-by: Timo K <[email protected]>

---------

Signed-off-by: Timo K <[email protected]>
Co-authored-by: Robin <[email protected]>

Author: toger5

src/models/Call.ts

@@ -70,21 +70,18 @@ const waitForEvent = async (
     let listener: (...args: any[]) => void;
     const wait = new Promise<void>((resolve) => {
         listener = (...args) => {
-            if (pred(...args)) {
-                resolve();
-                if (customTimeout === false) {
-                    emitter.off(event, listener!);
-                }
-            }
+            if (pred(...args)) resolve();
         };
         emitter.on(event, listener);
     });
 
     if (customTimeout !== false) {
         const timedOut = (await timeout(wait, false, customTimeout ?? TIMEOUT_MS)) === false;
-        emitter.off(event, listener!);
         if (timedOut) throw new Error("Timed out");
+    } else {
+        await wait;
     }
+    emitter.off(event, listener!);
 };
 
 export enum ConnectionState {