Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit 3c02b70

Browse files
authored
Merge pull request #994 from matrix-org/revert-989-add-language-picker-labels
Revert "add labels to language picker"
2 parents 53ebc8d + b3e9716 commit 3c02b70

File tree

2 files changed

+13
-15
lines changed

2 files changed

+13
-15
lines changed

src/components/views/elements/LanguageDropdown.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,14 @@ export default class LanguageDropdown extends React.Component {
4040
}
4141

4242
componentWillMount() {
43-
languageHandler.getAllLanguagesFromJson().then((langs) => {
43+
languageHandler.getAllLanguageKeysFromJson().then((langKeys) => {
44+
const langs = [];
45+
langKeys.forEach((languageKey) => {
46+
langs.push({
47+
value: languageKey,
48+
label: _t(languageKey)
49+
});
50+
});
4451
langs.sort(function(a, b){
4552
if(a.label < b.label) return -1;
4653
if(a.label > b.label) return 1;

src/languageHandler.js

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ export function setLanguage(preferredLangs) {
133133
throw new Error("Unable to find an appropriate language");
134134
}
135135

136-
return getLanguage(i18nFolder + availLangs[langToUse].fileName);
136+
return getLanguage(i18nFolder + availLangs[langToUse]);
137137
}).then((langData) => {
138138
counterpart.registerTranslations(langToUse, langData);
139139
counterpart.setLocale(langToUse);
@@ -142,25 +142,16 @@ export function setLanguage(preferredLangs) {
142142

143143
// Set 'en' as fallback language:
144144
if (langToUse != "en") {
145-
return getLanguage(i18nFolder + availLangs['en'].fileName);
145+
return getLanguage(i18nFolder + availLangs['en']);
146146
}
147147
}).then((langData) => {
148148
if (langData) counterpart.registerTranslations('en', langData);
149149
});
150150
};
151151

152-
export function getAllLanguagesFromJson() {
153-
return getLangsJson().then((langsObject) => {
154-
var langs = [];
155-
for (var langKey in langsObject) {
156-
if (langsObject.hasOwnProperty(langKey)) {
157-
langs.push({
158-
'value': langKey,
159-
'label': langsObject[langKey].label
160-
});
161-
}
162-
}
163-
return langs;
152+
export function getAllLanguageKeysFromJson() {
153+
return getLangsJson().then((langs) => {
154+
return Object.keys(langs);
164155
});
165156
}
166157

0 commit comments

Comments
 (0)