Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit 4d6643c

Browse files
authored
Fix freeze/crash when 1:1 calling (#8057) (#8058)
* Fix freeze/crash when 1:1 calling Don't log call feed objects because they reference the client and it causes the client to get logged too. * Log purpose too
1 parent e485907 commit 4d6643c

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/components/views/voip/AudioFeed.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,10 @@ export default class AudioFeed extends React.Component<IProps, IState> {
9393
// load() explicitly, it shouldn't be a problem. - Dave
9494
await element.load();
9595
} catch (e) {
96-
logger.info("Failed to play media element with feed", this.props.feed, e);
96+
logger.info(
97+
`Failed to play media element with feed for userId ` +
98+
`${this.props.feed.userId} with purpose ${this.props.feed.purpose}`, e,
99+
);
97100
}
98101
}
99102

src/components/views/voip/VideoFeed.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,10 @@ export default class VideoFeed extends React.PureComponent<IProps, IState> {
138138
// load() explicitly, it shouldn't be a problem. - Dave
139139
await element.play();
140140
} catch (e) {
141-
logger.info("Failed to play media element with feed", this.props.feed, e);
141+
logger.info(
142+
`Failed to play media element with feed for userId ` +
143+
`${this.props.feed.userId} with purpose ${this.props.feed.purpose}`, e,
144+
);
142145
}
143146
}
144147

0 commit comments

Comments
 (0)