Some small tidying up (#9149)

t3chguy · web-flow · commit 5fbeb20df864 · 2022-08-09T11:55:49.000Z
* Remove stale comment

* Fix typing

* Install katex type definitions
diff --git a/package.json b/package.json
@@ -150,6 +150,7 @@
     "@types/flux": "^3.1.9",
     "@types/fs-extra": "^9.0.13",
     "@types/jest": "^26.0.20",
+    "@types/katex": "^0.14.0",
     "@types/lodash": "^4.14.168",
     "@types/modernizr": "^3.5.3",
     "@types/node": "^14.14.22",
diff --git a/src/components/structures/MatrixChat.tsx b/src/components/structures/MatrixChat.tsx
@@ -157,7 +157,7 @@ interface IScreen {
     params?: QueryDict;
 }
 
-interface IProps { // TODO type things better
+interface IProps {
     config: IConfigOptions;
     serverConfig?: ValidatedServerConfig;
     onNewScreen: (screen: string, replaceLast: boolean) => void;
diff --git a/src/linkify-matrix.ts b/src/linkify-matrix.ts
@@ -130,8 +130,8 @@ function onAliasClick(event: MouseEvent, roomAlias: string) {
     });
 }
 
-const escapeRegExp = function(string): string {
-    return string.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+const escapeRegExp = function(s: string): string {
+    return s.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
 };
 
 // Recognise URLs from both our local and official Element deployments.
diff --git a/yarn.lock b/yarn.lock
@@ -2094,6 +2094,11 @@
   resolved "https://registry.yarnpkg.com/@types/json5/-/json5-0.0.29.tgz#ee28707ae94e11d2b827bcbe5270bcea7f3e71ee"
   integrity sha512-dRLjCWHYg4oaA77cxO64oO+7JwCwnIzkZPdrrC71jQmQtlhM556pwKo5bUzqvZndkVbeFLIIi+9TC40JNF5hNQ==
 
+"@types/katex@^0.14.0":
+  version "0.14.0"
+  resolved "https://registry.yarnpkg.com/@types/katex/-/katex-0.14.0.tgz#b84c0afc3218069a5ad64fe2a95321881021b5fe"
+  integrity sha512-+2FW2CcT0K3P+JMR8YG846bmDwplKUTsWgT2ENwdQ1UdVfRk3GQrh6Mi4sTopy30gI8Uau5CEqHTDZ6YvWIUPA==
+
 "@types/lodash@^4.14.168":
   version "4.14.182"
   resolved "https://registry.yarnpkg.com/@types/lodash/-/lodash-4.14.182.tgz#05301a4d5e62963227eaafe0ce04dd77c54ea5c2"

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ interface IScreen {`
`157`	`157`	`params?: QueryDict;`
`158`	`158`	`}`
`159`	`159`
`160`		`-interface IProps { // TODO type things better`
	`160`	`+interface IProps {`
`161`	`161`	`config: IConfigOptions;`
`162`	`162`	`serverConfig?: ValidatedServerConfig;`
`163`	`163`	`onNewScreen: (screen: string, replaceLast: boolean) => void;`
Original file line number	Diff line number	Diff line change
`@@ -130,8 +130,8 @@ function onAliasClick(event: MouseEvent, roomAlias: string) {`
`130`	`130`	`});`
`131`	`131`	`}`
`132`	`132`
`133`		`-const escapeRegExp = function(string): string {`
`134`		`- return string.replace(/[.*+?^${}()\|[\]\\]/g, "\\$&");`
	`133`	`+const escapeRegExp = function(s: string): string {`
	`134`	`+ return s.replace(/[.*+?^${}()\|[\]\\]/g, "\\$&");`
`135`	`135`	`};`
`136`	`136`
`137`	`137`	`// Recognise URLs from both our local and official Element deployments.`