[Backport staging] use correct default for notification silencing (#9389)

Co-authored-by: Kerry <[email protected]>

Author: RiotRobot

src/utils/notifications.ts

@@ -25,5 +25,5 @@ export function getLocalNotificationAccountDataEventType(deviceId: string): stri
 export function localNotificationsAreSilenced(cli: MatrixClient): boolean {
     const eventType = getLocalNotificationAccountDataEventType(cli.deviceId);
     const event = cli.getAccountData(eventType);
-    return event?.getContent<LocalNotificationSettings>()?.is_silenced ?? true;
+    return event?.getContent<LocalNotificationSettings>()?.is_silenced ?? false;
 }

test/utils/notifications-test.ts

@@ -47,8 +47,8 @@ describe('notifications', () => {
     });
 
     describe('localNotificationsAreSilenced', () => {
-        it('defaults to true when no setting exists', () => {
-            expect(localNotificationsAreSilenced(mockClient)).toBeTruthy();
+        it('defaults to false when no setting exists', () => {
+            expect(localNotificationsAreSilenced(mockClient)).toBeFalsy();
         });
         it('checks the persisted value', () => {
             mockClient.setAccountData(accountDataEventKey, { is_silenced: true });