Merge pull request #669 from matrix-org/dbkr/read_receipt_title

richvdh · web-flow · commit 68f644c82417 · 2017-02-02T15:25:45.000Z
Make read receipt's titles more explanatory
diff --git a/src/components/views/rooms/ReadReceiptMarker.js b/src/components/views/rooms/ReadReceiptMarker.js
@@ -170,15 +170,15 @@ module.exports = React.createClass({
 
         let title;
         if (this.props.timestamp) {
-            let suffix = " (" + this.props.member.userId + ")";
+            const prefix = "Seen by " + this.props.member.userId + " at ";
             let ts = new Date(this.props.timestamp);
             if (this.props.showFullTimestamp) {
                 // "15/12/2016, 7:05:45 PM (@alice:matrix.org)"
-                title = ts.toLocaleString() + suffix;
+                title = prefix + ts.toLocaleString();
             }
             else {
                 // "7:05:45 PM (@alice:matrix.org)"
-                title = ts.toLocaleTimeString() + suffix;
+                title = prefix + ts.toLocaleTimeString();
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -170,15 +170,15 @@ module.exports = React.createClass({`
`170`	`170`
`171`	`171`	`let title;`
`172`	`172`	`if (this.props.timestamp) {`
`173`		`- let suffix = " (" + this.props.member.userId + ")";`
	`173`	`+ const prefix = "Seen by " + this.props.member.userId + " at ";`
`174`	`174`	`let ts = new Date(this.props.timestamp);`
`175`	`175`	`if (this.props.showFullTimestamp) {`
`176`	`176`	`// "15/12/2016, 7:05:45 PM (@alice:matrix.org)"`
`177`		`- title = ts.toLocaleString() + suffix;`
	`177`	`+ title = prefix + ts.toLocaleString();`
`178`	`178`	`}`
`179`	`179`	`else {`
`180`	`180`	`// "7:05:45 PM (@alice:matrix.org)"`
`181`		`- title = ts.toLocaleTimeString() + suffix;`
	`181`	`+ title = prefix + ts.toLocaleTimeString();`
`182`	`182`	`}`
`183`	`183`	`}`
`184`	`184`