Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit 8ce6da1

Browse files
committed
Merge branch 'new_release_process_stable' into develop
This reverts all PRs currently marked notready, changing develop into a branch that should be more stable.
2 parents 6962346 + 75eea89 commit 8ce6da1

15 files changed

+124
-686
lines changed

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,11 @@
6565
"lodash": "^4.13.1",
6666
"matrix-js-sdk": "matrix-org/matrix-js-sdk#develop",
6767
"optimist": "^0.6.1",
68-
"prop-types": "^15.5.8",
6968
"q": "^1.4.1",
7069
"react": "^15.4.0",
7170
"react-addons-css-transition-group": "15.3.2",
7271
"react-dom": "^15.4.0",
73-
"react-gemini-scrollbar": "matrix-org/react-gemini-scrollbar#39d858c",
72+
"react-gemini-scrollbar": "matrix-org/react-gemini-scrollbar#5e97aef",
7473
"sanitize-html": "^1.11.1",
7574
"text-encoding-utf-8": "^1.0.1",
7675
"velocity-vector": "vector-im/velocity#059e3b2",

src/ConstantTimeDispatcher.js

Lines changed: 0 additions & 62 deletions
This file was deleted.

src/KeyCode.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,4 @@ module.exports = {
3232
DELETE: 46,
3333
KEY_D: 68,
3434
KEY_E: 69,
35-
KEY_K: 75,
3635
};

src/components/structures/LoggedInView.js

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -107,18 +107,6 @@ export default React.createClass({
107107
var handled = false;
108108

109109
switch (ev.keyCode) {
110-
case KeyCode.ESCAPE:
111-
112-
// Implemented this way so possible handling for other pages is neater
113-
switch (this.props.page_type) {
114-
case PageTypes.UserSettings:
115-
this.props.onUserSettingsClose();
116-
handled = true;
117-
break;
118-
}
119-
120-
break;
121-
122110
case KeyCode.UP:
123111
case KeyCode.DOWN:
124112
if (ev.altKey && !ev.shiftKey && !ev.ctrlKey && !ev.metaKey) {

src/components/structures/TimelinePanel.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,6 @@ var TimelinePanel = React.createClass({
590590
this.props.timelineSet.room.setUnreadNotificationCount('highlight', 0);
591591
dis.dispatch({
592592
action: 'on_room_read',
593-
room: this.props.timelineSet.room,
594593
});
595594
}
596595
}

src/components/views/dialogs/BaseDialog.js

Lines changed: 5 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -47,35 +47,18 @@ export default React.createClass({
4747
children: React.PropTypes.node,
4848
},
4949

50-
componentWillMount: function() {
51-
this.priorActiveElement = document.activeElement;
52-
},
53-
54-
componentWillUnmount: function() {
55-
if (this.priorActiveElement !== null) {
56-
this.priorActiveElement.focus();
57-
}
58-
},
59-
60-
// Don't let key{down,press} events escape the modal. Consume them all.
61-
_eatKeyEvent: function(e) {
62-
e.stopPropagation();
63-
},
64-
65-
// Must be when the key is released (and not pressed) otherwise componentWillUnmount
66-
// will focus another element which will receive future key events
67-
_onKeyUp: function(e) {
50+
_onKeyDown: function(e) {
6851
if (e.keyCode === KeyCode.ESCAPE) {
52+
e.stopPropagation();
6953
e.preventDefault();
7054
this.props.onFinished();
7155
} else if (e.keyCode === KeyCode.ENTER) {
7256
if (this.props.onEnterPressed) {
57+
e.stopPropagation();
7358
e.preventDefault();
7459
this.props.onEnterPressed(e);
7560
}
7661
}
77-
// Consume all keyup events while Modal is open
78-
e.stopPropagation();
7962
},
8063

8164
_onCancelClick: function(e) {
@@ -84,13 +67,9 @@ export default React.createClass({
8467

8568
render: function() {
8669
const TintableSvg = sdk.getComponent("elements.TintableSvg");
87-
70+
8871
return (
89-
<div onKeyUp={this._onKeyUp}
90-
onKeyDown={this._eatKeyEvent}
91-
onKeyPress={this._eatKeyEvent}
92-
className={this.props.className}
93-
>
72+
<div onKeyDown={this._onKeyDown} className={this.props.className}>
9473
<AccessibleButton onClick={this._onCancelClick}
9574
className="mx_Dialog_cancelButton"
9675
>

src/components/views/dialogs/QuestionDialog.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,6 @@ export default React.createClass({
4747
this.props.onFinished(false);
4848
},
4949

50-
componentDidMount: function() {
51-
if (this.props.focus) {
52-
this.refs.button.focus();
53-
}
54-
},
55-
5650
render: function() {
5751
const BaseDialog = sdk.getComponent('views.dialogs.BaseDialog');
5852
const cancelButton = this.props.hasCancelButton ? (
@@ -69,7 +63,7 @@ export default React.createClass({
6963
{this.props.description}
7064
</div>
7165
<div className="mx_Dialog_buttons">
72-
<button ref="button" className="mx_Dialog_primary" onClick={this.onOk}>
66+
<button className="mx_Dialog_primary" onClick={this.onOk} autoFocus={this.props.focus}>
7367
{this.props.button}
7468
</button>
7569
{this.props.extraButtons}

src/components/views/elements/ActionButton.js

Lines changed: 0 additions & 80 deletions
This file was deleted.

src/components/views/elements/CreateRoomButton.js

Lines changed: 0 additions & 38 deletions
This file was deleted.

src/components/views/elements/HomeButton.js

Lines changed: 0 additions & 38 deletions
This file was deleted.

0 commit comments

Comments
 (0)