Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit bef20dd

Browse files
authored
Merge pull request #6177 from matrix-org/gsouquet/benchmark-tracking
2 parents 3eca1cb + 7310d35 commit bef20dd

File tree

3 files changed

+22
-6
lines changed

3 files changed

+22
-6
lines changed

.github/workflows/develop.yml

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,19 @@ jobs:
2020
test/end-to-end-tests/logs/**/*
2121
test/end-to-end-tests/synapse/installations/consent/homeserver.log
2222
retention-days: 14
23-
- name: Archive performance benchmark
24-
uses: actions/upload-artifact@v2
23+
- name: Download previous benchmark data
24+
uses: actions/cache@v1
25+
with:
26+
path: ./cache
27+
key: ${{ runner.os }}-benchmark
28+
- name: Store benchmark result
29+
uses: matrix-org/github-action-benchmark@jsperfentry-1
2530
with:
26-
name: performance-entries.json
27-
path: test/end-to-end-tests/performance-entries.json
31+
tool: 'jsperformanceentry'
32+
output-file-path: test/end-to-end-tests/performance-entries.json
33+
fail-on-alert: false
34+
comment-on-alert: true
35+
# Only temporary to monitor where failures occur
36+
alert-comment-cc-users: '@gsouquet'
37+
github-token: ${{ secrets.DEPLOY_GH_PAGES }}
38+
auto-push: ${{ github.ref == 'refs/heads/develop' }}

src/components/structures/MatrixChat.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1953,6 +1953,7 @@ export default class MatrixChat extends React.PureComponent<IProps, IState> {
19531953
// Create and start the client
19541954
await Lifecycle.setLoggedIn(credentials);
19551955
await this.postLoginSetup();
1956+
19561957
PerformanceMonitor.instance.stop(PerformanceEntryNames.LOGIN);
19571958
PerformanceMonitor.instance.stop(PerformanceEntryNames.REGISTER);
19581959
};

test/end-to-end-tests/start.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ async function runTests() {
7979
await new Promise((resolve) => setTimeout(resolve, 5 * 60 * 1000));
8080
}
8181

82-
const performanceEntries = {};
82+
let performanceEntries;
8383

8484
await Promise.all(sessions.map(async (session) => {
8585
// Collecting all performance monitoring data before closing the session
@@ -95,7 +95,11 @@ async function runTests() {
9595
}, true);
9696
return measurements;
9797
});
98-
performanceEntries[session.username] = JSON.parse(measurements);
98+
99+
/**
100+
* TODO: temporary only use one user session data
101+
*/
102+
performanceEntries = JSON.parse(measurements);
99103
return session.close();
100104
}));
101105
fs.writeFileSync(`performance-entries.json`, JSON.stringify(performanceEntries));

0 commit comments

Comments
 (0)