Use a more correct test for emoji (#7685)

Author: robintown

src/HtmlUtils.tsx

@@ -90,7 +90,7 @@ const MEDIA_API_MXC_REGEX = /\/_matrix\/media\/r0\/(?:download|thumbnail)\/(.+?)
  * positives, but useful for fast-path testing strings to see if they
  * need emojification.
  */
-export function mightContainEmoji(str: string): boolean {
+function mightContainEmoji(str: string): boolean {
     return SURROGATE_PAIR_PATTERN.test(str) || SYMBOL_PATTERN.test(str);
 }
 
@@ -432,7 +432,7 @@ function formatEmojis(message: string, isHtmlMessage: boolean): (JSX.Element | s
 
     // We use lodash's grapheme splitter to avoid breaking apart compound emojis
     for (const char of split(message, '')) {
-        if (mightContainEmoji(char)) {
+        if (EMOJIBASE_REGEX.test(char)) {
             if (text) {
                 result.push(text);
                 text = '';

src/editor/parts.ts

@@ -16,6 +16,7 @@ limitations under the License.
 */
 
 import { split } from "lodash";
+import EMOJIBASE_REGEX from "emojibase-regex";
 import { MatrixClient } from "matrix-js-sdk/src/client";
 import { RoomMember } from "matrix-js-sdk/src/models/room-member";
 import { Room } from "matrix-js-sdk/src/models/room";
@@ -25,7 +26,7 @@ import AutocompleteWrapperModel, {
     UpdateCallback,
     UpdateQuery,
 } from "./autocomplete";
-import { mightContainEmoji, unicodeToShortcode } from "../HtmlUtils";
+import { unicodeToShortcode } from "../HtmlUtils";
 import * as Avatar from "../Avatar";
 import defaultDispatcher from "../dispatcher/dispatcher";
 import { Action } from "../dispatcher/actions";
@@ -191,7 +192,7 @@ abstract class BasePart {
 
 abstract class PlainBasePart extends BasePart {
     protected acceptsInsertion(chr: string, offset: number, inputType: string): boolean {
-        if (chr === "\n" || mightContainEmoji(chr)) {
+        if (chr === "\n" || EMOJIBASE_REGEX.test(chr)) {
             return false;
         }
         // when not pasting or dropping text, reject characters that should start a pill candidate
@@ -361,7 +362,7 @@ class NewlinePart extends BasePart implements IBasePart {
 
 class EmojiPart extends BasePart implements IBasePart {
     protected acceptsInsertion(chr: string, offset: number): boolean {
-        return mightContainEmoji(chr);
+        return EMOJIBASE_REGEX.test(chr);
     }
 
     protected acceptsRemoval(position: number, chr: string): boolean {
@@ -553,7 +554,7 @@ export class PartCreator {
             case "\n":
                 return new NewlinePart();
             default:
-                if (mightContainEmoji(input[0])) {
+                if (EMOJIBASE_REGEX.test(input[0])) {
                     return new EmojiPart();
                 }
                 return new PlainPart();
@@ -627,7 +628,7 @@ export class PartCreator {
 
         // We use lodash's grapheme splitter to avoid breaking apart compound emojis
         for (const char of split(text, "")) {
-            if (mightContainEmoji(char)) {
+            if (EMOJIBASE_REGEX.test(char)) {
                 if (plainText) {
                     parts.push(this.plain(plainText));
                     plainText = "";