Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit c07cd24

Browse files
Kerryandybalaam
andauthored
Ended poll tiles: add ended the poll message (#10193)
* add ended the poll message to ended poll tile * fussy import ordering --------- Co-authored-by: Andy Balaam <[email protected]>
1 parent c29e5f1 commit c07cd24

File tree

3 files changed

+77
-62
lines changed

3 files changed

+77
-62
lines changed

src/components/views/messages/MPollEndBody.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ import { logger } from "matrix-js-sdk/src/logger";
2121

2222
import { Icon as PollIcon } from "../../../../res/img/element-icons/room/composer/poll.svg";
2323
import MatrixClientContext from "../../../contexts/MatrixClientContext";
24+
import { _t } from "../../../languageHandler";
2425
import { textForEvent } from "../../../TextForEvent";
26+
import { Caption } from "../typography/Caption";
2527
import { IBodyProps } from "./IBodyProps";
2628
import MPollBody from "./MPollBody";
2729

@@ -105,5 +107,10 @@ export const MPollEndBody = React.forwardRef<any, IBodyProps>(({ mxEvent, ...pro
105107
);
106108
}
107109

108-
return <MPollBody mxEvent={pollStartEvent} {...props} />;
110+
return (
111+
<div>
112+
<Caption>{_t("Ended a poll")}</Caption>
113+
<MPollBody mxEvent={pollStartEvent} {...props} />
114+
</div>
115+
);
109116
});

src/i18n/strings/en_EN.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2415,6 +2415,7 @@
24152415
"Based on %(count)s votes|other": "Based on %(count)s votes",
24162416
"Based on %(count)s votes|one": "Based on %(count)s vote",
24172417
"edited": "edited",
2418+
"Ended a poll": "Ended a poll",
24182419
"Error decrypting video": "Error decrypting video",
24192420
"Error processing voice message": "Error processing voice message",
24202421
"Add reaction": "Add reaction",

test/components/views/messages/__snapshots__/MPollEndBody-test.tsx.snap

Lines changed: 68 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -10,99 +10,106 @@ exports[`<MPollEndBody /> when poll start event does not exist in current timeli
1010

1111
exports[`<MPollEndBody /> when poll start event exists in current timeline renders an ended poll 1`] = `
1212
<div>
13-
<div
14-
class="mx_MPollBody"
15-
>
16-
<h2
17-
data-testid="pollQuestion"
13+
<div>
14+
<span
15+
class="mx_Caption"
1816
>
19-
Question?
20-
</h2>
17+
Ended a poll
18+
</span>
2119
<div
22-
class="mx_MPollBody_allOptions"
20+
class="mx_MPollBody"
2321
>
22+
<h2
23+
data-testid="pollQuestion"
24+
>
25+
Question?
26+
</h2>
2427
<div
25-
class="mx_PollOption mx_PollOption_ended"
26-
data-testid="pollOption-socks"
28+
class="mx_MPollBody_allOptions"
2729
>
2830
<div
29-
class="mx_PollOption_endedOption"
30-
data-value="socks"
31+
class="mx_PollOption mx_PollOption_ended"
32+
data-testid="pollOption-socks"
3133
>
3234
<div
33-
class="mx_PollOption_content"
35+
class="mx_PollOption_endedOption"
36+
data-value="socks"
3437
>
3538
<div
36-
class="mx_PollOption_optionText"
37-
>
38-
Socks
39-
</div>
40-
<div
41-
class="mx_PollOption_optionVoteCount"
39+
class="mx_PollOption_content"
4240
>
43-
0 votes
41+
<div
42+
class="mx_PollOption_optionText"
43+
>
44+
Socks
45+
</div>
46+
<div
47+
class="mx_PollOption_optionVoteCount"
48+
>
49+
0 votes
50+
</div>
4451
</div>
4552
</div>
46-
</div>
47-
<div
48-
class="mx_PollOption_popularityBackground"
49-
>
5053
<div
51-
class="mx_PollOption_popularityAmount"
52-
style="width: 0%;"
53-
/>
54+
class="mx_PollOption_popularityBackground"
55+
>
56+
<div
57+
class="mx_PollOption_popularityAmount"
58+
style="width: 0%;"
59+
/>
60+
</div>
5461
</div>
55-
</div>
56-
<div
57-
class="mx_PollOption mx_PollOption_ended"
58-
data-testid="pollOption-shoes"
59-
>
6062
<div
61-
class="mx_PollOption_endedOption"
62-
data-value="shoes"
63+
class="mx_PollOption mx_PollOption_ended"
64+
data-testid="pollOption-shoes"
6365
>
6466
<div
65-
class="mx_PollOption_content"
67+
class="mx_PollOption_endedOption"
68+
data-value="shoes"
6669
>
6770
<div
68-
class="mx_PollOption_optionText"
71+
class="mx_PollOption_content"
6972
>
70-
Shoes
73+
<div
74+
class="mx_PollOption_optionText"
75+
>
76+
Shoes
77+
</div>
78+
<div
79+
class="mx_PollOption_optionVoteCount"
80+
>
81+
0 votes
82+
</div>
7183
</div>
84+
</div>
85+
<div
86+
class="mx_PollOption_popularityBackground"
87+
>
7288
<div
73-
class="mx_PollOption_optionVoteCount"
74-
>
75-
0 votes
76-
</div>
89+
class="mx_PollOption_popularityAmount"
90+
style="width: 0%;"
91+
/>
7792
</div>
7893
</div>
94+
</div>
95+
<div
96+
class="mx_MPollBody_totalVotes"
97+
data-testid="totalVotes"
98+
>
99+
Final result based on 0 votes
79100
<div
80-
class="mx_PollOption_popularityBackground"
101+
class="mx_Spinner"
81102
>
82103
<div
83-
class="mx_PollOption_popularityAmount"
84-
style="width: 0%;"
104+
aria-label="Loading…"
105+
class="mx_Spinner_icon"
106+
data-testid="spinner"
107+
role="progressbar"
108+
style="width: 16px; height: 16px;"
85109
/>
86110
</div>
87111
</div>
88112
</div>
89-
<div
90-
class="mx_MPollBody_totalVotes"
91-
data-testid="totalVotes"
92-
>
93-
Final result based on 0 votes
94-
<div
95-
class="mx_Spinner"
96-
>
97-
<div
98-
aria-label="Loading…"
99-
class="mx_Spinner_icon"
100-
data-testid="spinner"
101-
role="progressbar"
102-
style="width: 16px; height: 16px;"
103-
/>
104-
</div>
105-
</div>
106113
</div>
107114
</div>
108115
`;

0 commit comments

Comments
 (0)