Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit c6c56e0

Browse files
authored
Merge pull request #5938 from matrix-org/revert-5917-Redact
Revert "Fixes the two Todays problem in Redaction"
2 parents ec4ac05 + b90c845 commit c6c56e0

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

src/components/structures/MessagePanel.js

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ export default class MessagePanel extends React.Component {
562562
return ret;
563563
}
564564

565-
_getTilesForEvent(prevEvent, mxEv, last, isGrouped=false, nextEvent, nextEventWithTile) {
565+
_getTilesForEvent(prevEvent, mxEv, last, nextEvent, nextEventWithTile) {
566566
const TileErrorBoundary = sdk.getComponent('messages.TileErrorBoundary');
567567
const EventTile = sdk.getComponent('rooms.EventTile');
568568
const DateSeparator = sdk.getComponent('messages.DateSeparator');
@@ -582,7 +582,7 @@ export default class MessagePanel extends React.Component {
582582

583583
// do we need a date separator since the last event?
584584
const wantsDateSeparator = this._wantsDateSeparator(prevEvent, eventDate);
585-
if (wantsDateSeparator && !isGrouped) {
585+
if (wantsDateSeparator) {
586586
const dateSeparator = <li key={ts1}><DateSeparator key={ts1} ts={ts1} /></li>;
587587
ret.push(dateSeparator);
588588
}
@@ -966,6 +966,7 @@ class CreationGrouper {
966966

967967
const DateSeparator = sdk.getComponent('messages.DateSeparator');
968968
const EventListSummary = sdk.getComponent('views.elements.EventListSummary');
969+
969970
const panel = this.panel;
970971
const ret = [];
971972
const createEvent = this.createEvent;
@@ -981,7 +982,7 @@ class CreationGrouper {
981982
// If this m.room.create event should be shown (room upgrade) then show it before the summary
982983
if (panel._shouldShowEvent(createEvent)) {
983984
// pass in the createEvent as prevEvent as well so no extra DateSeparator is rendered
984-
ret.push(...panel._getTilesForEvent(createEvent, createEvent));
985+
ret.push(...panel._getTilesForEvent(createEvent, createEvent, false));
985986
}
986987

987988
for (const ejected of this.ejectedEvents) {
@@ -1080,7 +1081,7 @@ class RedactionGrouper {
10801081

10811082
const DateSeparator = sdk.getComponent('messages.DateSeparator');
10821083
const EventListSummary = sdk.getComponent('views.elements.EventListSummary');
1083-
const isGrouped=true;
1084+
10841085
const panel = this.panel;
10851086
const ret = [];
10861087
const lastShownEvent = this.lastShownEvent;
@@ -1097,12 +1098,10 @@ class RedactionGrouper {
10971098
);
10981099

10991100
const senders = new Set();
1100-
11011101
let eventTiles = this.events.map((e, i) => {
11021102
senders.add(e.sender);
11031103
const prevEvent = i === 0 ? this.prevEvent : this.events[i - 1];
1104-
return panel._getTilesForEvent(
1105-
prevEvent, e, e === lastShownEvent, isGrouped, this.nextEvent, this.nextEventTile);
1104+
return panel._getTilesForEvent(prevEvent, e, e === lastShownEvent, this.nextEvent, this.nextEventTile);
11061105
}).reduce((a, b) => a.concat(b), []);
11071106

11081107
if (eventTiles.length === 0) {
@@ -1181,7 +1180,7 @@ class MemberGrouper {
11811180

11821181
const DateSeparator = sdk.getComponent('messages.DateSeparator');
11831182
const MemberEventListSummary = sdk.getComponent('views.elements.MemberEventListSummary');
1184-
const isGrouped=true;
1183+
11851184
const panel = this.panel;
11861185
const lastShownEvent = this.lastShownEvent;
11871186
const ret = [];
@@ -1214,7 +1213,7 @@ class MemberGrouper {
12141213
// of MemberEventListSummary, render each member event as if the previous
12151214
// one was itself. This way, the timestamp of the previous event === the
12161215
// timestamp of the current event, and no DateSeparator is inserted.
1217-
return panel._getTilesForEvent(e, e, e === lastShownEvent, isGrouped);
1216+
return panel._getTilesForEvent(e, e, e === lastShownEvent);
12181217
}).reduce((a, b) => a.concat(b), []);
12191218

12201219
if (eventTiles.length === 0) {

0 commit comments

Comments
 (0)