Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit d7f4e7c

Browse files
authored
Merge pull request #1247 from matrix-org/luke/fix-rte-offset-bug
Use `data-offset-key` in RTE decorators
2 parents b372e5d + eccdcea commit d7f4e7c

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/components/views/elements/Pill.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,11 +173,11 @@ const Pill = React.createClass({
173173

174174
if (this.state.pillType) {
175175
return this.props.inMessage ?
176-
<a className={classes} href={this.props.url} title={resource}>
176+
<a className={classes} href={this.props.url} title={resource} data-offset-key={this.props.offsetKey}>
177177
{avatar}
178178
{linkText}
179179
</a> :
180-
<span className={classes} title={resource}>
180+
<span className={classes} title={resource} data-offset-key={this.props.offsetKey}>
181181
{avatar}
182182
{linkText}
183183
</span>;

src/components/views/rooms/MessageComposerInput.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -186,16 +186,16 @@ export default class MessageComposerInput extends React.Component {
186186
RichText.getScopedMDDecorators(this.props);
187187
decorators.push({
188188
strategy: this.findLinkEntities.bind(this),
189-
component: (props) => {
189+
component: (entityProps) => {
190190
const Pill = sdk.getComponent('elements.Pill');
191-
const {url} = Entity.get(props.entityKey).getData();
191+
const {url} = Entity.get(entityProps.entityKey).getData();
192192
if (Pill.isPillUrl(url)) {
193-
return <Pill url={url} room={this.props.room}/>;
193+
return <Pill url={url} room={this.props.room} offsetKey={entityProps.offsetKey}/>;
194194
}
195195

196196
return (
197-
<a href={url}>
198-
{props.children}
197+
<a href={url} data-offset-key={entityProps.offsetKey}>
198+
{entityProps.children}
199199
</a>
200200
);
201201
},

0 commit comments

Comments
 (0)