Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit dce047e

Browse files
authored
Merge pull request #5317 from matrix-org/t3chguy/fix/11510
Fix broken rendering of Room Create when showHiddenEvents enabled
2 parents e3155fe + 3faf28f commit dce047e

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/components/views/messages/RoomCreate.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export default class RoomCreate extends React.Component {
4545
render() {
4646
const predecessor = this.props.mxEvent.getContent()['predecessor'];
4747
if (predecessor === undefined) {
48-
return <div />; // We should never have been instaniated in this case
48+
return <div />; // We should never have been instantiated in this case
4949
}
5050
const prevRoom = MatrixClientPeg.get().getRoom(predecessor['room_id']);
5151
const permalinkCreator = new RoomPermalinkCreator(prevRoom, predecessor['room_id']);

src/components/views/rooms/EventTile.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -657,8 +657,7 @@ export default class EventTile extends React.Component {
657657
// source tile when there's no regular tile for an event and also for
658658
// replace relations (which otherwise would display as a confusing
659659
// duplicate of the thing they are replacing).
660-
const useSource = !tileHandler || this.props.mxEvent.isRelation("m.replace");
661-
if (useSource && SettingsStore.getValue("showHiddenEventsInTimeline")) {
660+
if (SettingsStore.getValue("showHiddenEventsInTimeline") && !haveTileForEvent(this.props.mxEvent)) {
662661
tileHandler = "messages.ViewSourceEvent";
663662
// Reuse info message avatar and sender profile styling
664663
isInfoMessage = true;

0 commit comments

Comments
 (0)