Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit dfdb613

Browse files
authored
Update Element Call URL generation to match new parameter semantics (#11749)
The semantics of the preload parameter are changing as detailed here, meaning we now have to additionally specify skipLobby to get the desired behavior out of Element Call: element-hq/element-call#1730
1 parent 5a0ebbf commit dfdb613

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/models/Call.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -642,9 +642,10 @@ export class ElementCall extends Call {
642642

643643
// Splice together the Element Call URL for this call
644644
const params = new URLSearchParams({
645-
embed: "",
646-
preload: "",
647-
hideHeader: "",
645+
embed: "true", // We're embedding EC within another application
646+
preload: "true", // We want it to load in the background
647+
skipLobby: "true", // Skip the lobby since we show a lobby component of our own
648+
hideHeader: "true", // Hide the header since our room header is enough
648649
userId: client.getUserId()!,
649650
deviceId: client.getDeviceId()!,
650651
roomId: groupCall.room.roomId,

0 commit comments

Comments
 (0)