Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit e32c499

Browse files
authored
Merge pull request #1320 from matrix-org/rxl881/timeline
Timeline improvements
2 parents b678c2c + 7395f96 commit e32c499

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

src/TextForEvent.js

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -252,18 +252,21 @@ function textForWidgetEvent(event) {
252252
const senderName = event.sender ? event.sender.name : event.getSender();
253253
const previousContent = event.getPrevContent() || {};
254254
const {name, type, url} = event.getContent() || {};
255-
let widgetName = widgetName || name || type || previousContent.type;
256-
widgetName = widgetName ? widgetName + ' ' : '';
255+
let widgetName = name || previousContent.name || type || previousContent.type || '';
256+
// Apply sentence case to widget name
257+
if (widgetName && widgetName.length > 0) {
258+
widgetName = widgetName[0].toUpperCase() + widgetName.slice(1) + ' ';
259+
}
257260

258261
// If the widget was removed, its content should be {}, but this is sufficiently
259262
// equivalent to that condition.
260263
if (url) {
261-
return _t('%(senderName)s added a %(widgetName)swidget', {
262-
senderName, widgetName,
264+
return _t('%(widgetName)s widget added by %(senderName)s', {
265+
widgetName, senderName,
263266
});
264267
} else {
265-
return _t('%(senderName)s removed a %(widgetName)swidget', {
266-
senderName, widgetName,
268+
return _t('%(widgetName)s widget removed by %(senderName)s', {
269+
widgetName, senderName,
267270
});
268271
}
269272
}

src/i18n/strings/en_EN.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -972,7 +972,7 @@
972972
"Failed to upload image": "Failed to upload image",
973973
"Failed to update group": "Failed to update group",
974974
"Hide avatars in user and room mentions": "Hide avatars in user and room mentions",
975-
"%(senderName)s added a %(widgetName)swidget": "%(senderName)s added a %(widgetName)swidget",
976-
"%(senderName)s removed a %(widgetName)swidget": "%(senderName)s removed a %(widgetName)swidget",
975+
"%(widgetName)s widget added by %(senderName)s": "%(widgetName)s widget added by %(senderName)s",
976+
"%(widgetName)s widget removed by %(senderName)s": "%(widgetName)s widget removed by %(senderName)s",
977977
"Robot check is currently unavailable on desktop - please use a <a>web browser</a>": "Robot check is currently unavailable on desktop - please use a <a>web browser</a>"
978978
}

0 commit comments

Comments
 (0)