chore(spaces): ignore room list change updates if empty

Author: stefanceriu

crates/matrix-sdk-base/src/sync.rs

@@ -97,6 +97,15 @@ impl RoomUpdates {
             .chain(self.invited.keys())
             .chain(self.knocked.keys())
     }
+
+    /// Returns whether or not this update contains any changes to the list
+    /// of invited, joined, knocked or left rooms.
+    pub fn is_empty(&self) -> bool {
+        self.invited.is_empty()
+            && self.joined.is_empty()
+            && self.knocked.is_empty()
+            && self.left.is_empty()
+    }
 }
 
 #[cfg(test)]

crates/matrix-sdk-ui/src/spaces/mod.rs

@@ -77,7 +77,11 @@ impl SpaceService {
 
                 loop {
                     match all_room_updates_receiver.recv().await {
-                        Ok(_) => {
+                        Ok(updates) => {
+                            if updates.is_empty() {
+                                continue;
+                            }
+
                             let new_spaces = Vector::from(Self::joined_spaces_for(&client).await);
                             Self::update_joined_spaces_if_needed(new_spaces, &joined_spaces);
                         }

crates/matrix-sdk-ui/src/spaces/room_list.rs

@@ -66,6 +66,10 @@ impl SpaceRoomList {
             loop {
                 match all_room_updates_receiver.recv().await {
                     Ok(updates) => {
+                        if updates.is_empty() {
+                            continue;
+                        }
+
                         let mut mutable_rooms = rooms_clone.lock();
 
                         updates.iter_all_room_ids().for_each(|updated_room_id| {