Skip to content

Commit 6814e70

Browse files
jplattebnjbvr
authored andcommitted
refactor: Simplify some methods of FailuresCache
Follow-up to #5490.
1 parent efa4539 commit 6814e70

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

crates/matrix-sdk-common/src/failures_cache.rs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,7 @@ where
101101
T: Borrow<Q>,
102102
Q: Hash + Eq + ?Sized,
103103
{
104-
let lock = self.inner.items.read();
105-
if let Some(item) = lock.get(key) { !item.expired() } else { false }
104+
self.inner.items.read().get(key).is_some_and(|item| !item.expired())
106105
}
107106

108107
/// Get the failure count for a given key.
@@ -120,8 +119,7 @@ where
120119
T: Borrow<Q>,
121120
Q: Hash + Eq + ?Sized,
122121
{
123-
let lock = self.inner.items.read();
124-
lock.get(key).map(|i| i.failure_count)
122+
self.inner.items.read().get(key).map(|i| i.failure_count)
125123
}
126124

127125
/// This will calculate a duration that determines how long an item is
@@ -187,8 +185,7 @@ where
187185
/// for immediate retry.
188186
#[doc(hidden)]
189187
pub fn expire(&self, item: &T) {
190-
let mut lock = self.inner.items.write();
191-
lock.get_mut(item).map(FailuresItem::expire);
188+
self.inner.items.write().get_mut(item).map(FailuresItem::expire);
192189
}
193190
}
194191

0 commit comments

Comments
 (0)