chore(base): Move Room::get_member_hints in the display_name module.

This patch moves the `Room::get_member_hints` method inside the newly
created `display_name` module. That way it is isolated from the rest of
the codebase.

Author: Hywan

crates/matrix-sdk-base/src/rooms/display_name.rs

@@ -14,12 +14,20 @@
 
 use std::fmt;
 
+use as_variant::as_variant;
 use regex::Regex;
-use ruma::{events::member_hints::MemberHintsEventContent, OwnedMxcUri, OwnedUserId, UserId};
+use ruma::{
+    events::{member_hints::MemberHintsEventContent, SyncStateEvent},
+    OwnedMxcUri, OwnedUserId, UserId,
+};
 use serde::{Deserialize, Serialize};
 use tracing::{debug, trace, warn};
 
-use crate::{store::Result as StoreResult, RoomMember, RoomState};
+use crate::{
+    deserialized_responses::SyncOrStrippedState,
+    store::{Result as StoreResult, StateStoreExt},
+    RoomMember, RoomState,
+};
 
 use super::{Room, RoomMemberships};
 
@@ -291,6 +299,21 @@ impl Room {
 
         Ok(ComputedSummary { heroes, num_service_members, num_joined_invited_guess })
     }
+
+    async fn get_member_hints(&self) -> StoreResult<MemberHintsEventContent> {
+        Ok(self
+            .store
+            .get_state_event_static::<MemberHintsEventContent>(self.room_id())
+            .await?
+            .and_then(|event| {
+                event
+                    .deserialize()
+                    .inspect_err(|e| warn!("Couldn't deserialize the member hints event: {e}"))
+                    .ok()
+            })
+            .and_then(|event| as_variant!(event, SyncOrStrippedState::Sync(SyncStateEvent::Original(e)) => e.content))
+            .unwrap_or_default())
+    }
 }
 
 /// The result of a room summary computation.

crates/matrix-sdk-base/src/rooms/mod.rs

@@ -26,14 +26,13 @@ mod state;
 mod tags;
 
 use crate::{
-    deserialized_responses::{MemberEvent, SyncOrStrippedState},
+    deserialized_responses::MemberEvent,
     notification_settings::RoomNotificationMode,
     read_receipts::RoomReadReceipts,
     store::{DynStateStore, Result as StoreResult, StateStoreExt},
     sync::UnreadNotificationsCount,
     Error, MinimalStateEvent,
 };
-use as_variant::as_variant;
 pub use create::*;
 pub use display_name::{RoomDisplayName, RoomHero};
 pub(crate) use display_name::{RoomSummary, UpdatedRoomDisplayName};
@@ -52,7 +51,6 @@ use ruma::{events::AnySyncTimelineEvent, serde::Raw};
 use ruma::{
     events::{
         direct::OwnedDirectUserIdentifier,
-        member_hints::MemberHintsEventContent,
         receipt::{Receipt, ReceiptThread, ReceiptType},
         room::{
             avatar::{self},
@@ -62,7 +60,6 @@ use ruma::{
             power_levels::{RoomPowerLevels, RoomPowerLevelsEventContent},
             tombstone::RoomTombstoneEventContent,
         },
-        SyncStateEvent,
     },
     room::RoomType,
     EventId, OwnedEventId, OwnedMxcUri, OwnedRoomAliasId, OwnedRoomId, OwnedUserId, RoomId, UserId,
@@ -391,21 +388,6 @@ impl Room {
         self.inner.read().topic().map(ToOwned::to_owned)
     }
 
-    pub(super) async fn get_member_hints(&self) -> StoreResult<MemberHintsEventContent> {
-        Ok(self
-            .store
-            .get_state_event_static::<MemberHintsEventContent>(self.room_id())
-            .await?
-            .and_then(|event| {
-                event
-                    .deserialize()
-                    .inspect_err(|e| warn!("Couldn't deserialize the member hints event: {e}"))
-                    .ok()
-            })
-            .and_then(|event| as_variant!(event, SyncOrStrippedState::Sync(SyncStateEvent::Original(e)) => e.content))
-            .unwrap_or_default())
-    }
-
     /// Update the cached user defined notification mode.
     ///
     /// This is automatically recomputed on every successful sync, and the