review: refactor, rename NotProcessed variant to Invalid

Author: BillCarsonFr

crates/matrix-sdk-crypto/src/machine/mod.rs

@@ -1294,7 +1294,7 @@ impl OlmMachine {
             Err(e) => {
                 // Skip invalid events.
                 warn!("Received an invalid to-device event: {e}");
-                return Some(ProcessedToDeviceEvent::NotProcessed(raw_event));
+                return Some(ProcessedToDeviceEvent::Invalid(raw_event));
             }
         };
 

crates/matrix-sdk-crypto/src/machine/tests/send_encrypted_to_device.rs

@@ -214,7 +214,7 @@ async fn test_processed_to_device_variants() {
     assert_matches!(processed_event, ProcessedToDeviceEvent::PlainText(_));
 
     let processed_event = &processed[2];
-    assert_matches!(processed_event, ProcessedToDeviceEvent::NotProcessed(_));
+    assert_matches!(processed_event, ProcessedToDeviceEvent::Invalid(_));
 
     let processed_event = &processed[3];
     assert_matches!(processed_event, ProcessedToDeviceEvent::UnableToDecrypt { .. });

crates/matrix-sdk-crypto/src/types/mod.rs

@@ -642,8 +642,10 @@ pub enum ProcessedToDeviceEvent {
     /// An unencrypted event.
     PlainText(Raw<AnyToDeviceEvent>),
 
-    /// An invalid to device event that was ignored
-    NotProcessed(Raw<AnyToDeviceEvent>),
+    /// An invalid to device event that was ignored because it is missing some
+    /// required information to be processed (like no event `type` for
+    /// example)
+    Invalid(Raw<AnyToDeviceEvent>),
 }
 
 impl ProcessedToDeviceEvent {
@@ -654,7 +656,7 @@ impl ProcessedToDeviceEvent {
             ProcessedToDeviceEvent::Decrypted(decrypted_event) => decrypted_event.clone(),
             ProcessedToDeviceEvent::UnableToDecrypt(event) => event.clone(),
             ProcessedToDeviceEvent::PlainText(event) => event.clone(),
-            ProcessedToDeviceEvent::NotProcessed(event) => event.clone(),
+            ProcessedToDeviceEvent::Invalid(event) => event.clone(),
         }
     }
 }