Skip to content

Commit cb7814b

Browse files
toger5bnjbvr
authored andcommitted
MatrixRTC: bump ruma to be compatible with MSC4143.
Adapt types for the new ruma version.
1 parent b34a2cd commit cb7814b

File tree

5 files changed

+27
-28
lines changed

5 files changed

+27
-28
lines changed

Cargo.lock

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ once_cell = "1.16.0"
4444
pin-project-lite = "0.2.9"
4545
rand = "0.8.5"
4646
reqwest = { version = "0.12.4", default-features = false }
47-
ruma = { git = "https://github.com/ruma/ruma", rev = "75e8829bec0b7bc5332860e1fb2df658d5c71d66", features = [
47+
ruma = { git = "https://github.com/ruma/ruma", rev = "c21817436979acbe66d43064498920a6d289b562", features = [
4848
"client-api-c",
4949
"compat-upload-signatures",
5050
"compat-user-id",
@@ -55,7 +55,7 @@ ruma = { git = "https://github.com/ruma/ruma", rev = "75e8829bec0b7bc5332860e1fb
5555
"unstable-msc3266",
5656
"unstable-msc4075"
5757
] }
58-
ruma-common = { git = "https://github.com/ruma/ruma", rev = "75e8829bec0b7bc5332860e1fb2df658d5c71d66" }
58+
ruma-common = { git = "https://github.com/ruma/ruma", rev = "c21817436979acbe66d43064498920a6d289b562" }
5959
serde = "1.0.151"
6060
serde_html_form = "0.2.0"
6161
serde_json = "1.0.91"

bindings/matrix-sdk-ffi/src/room.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ impl Room {
134134

135135
/// Returns a Vec of userId's that participate in the room call.
136136
///
137-
/// matrix_rtc memberships with application "m.call" and scope "m.room" are
137+
/// MatrixRTC memberships with application "m.call" and scope "m.room" are
138138
/// considered. A user can occur twice if they join with two devices.
139139
/// convert to a set depending if the different users are required or the
140140
/// amount of sessions.

crates/matrix-sdk-base/src/rooms/normal.rs

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ use ruma::events::AnySyncTimelineEvent;
2929
use ruma::{
3030
api::client::sync::sync_events::v3::RoomSummary as RumaSummary,
3131
events::{
32-
call::member::Membership,
32+
call::member::MembershipData,
3333
ignored_user_list::IgnoredUserListEventContent,
3434
receipt::{Receipt, ReceiptThread, ReceiptType},
3535
room::{
@@ -462,7 +462,7 @@ impl Room {
462462

463463
/// Returns a Vec of userId's that participate in the room call.
464464
///
465-
/// matrix_rtc memberships with application "m.call" and scope "m.room" are
465+
/// MatrixRTC memberships with application "m.call" and scope "m.room" are
466466
/// considered. A user can occur twice if they join with two devices.
467467
/// convert to a set depending if the different users are required or the
468468
/// amount of sessions.
@@ -1289,7 +1289,7 @@ impl RoomInfo {
12891289
/// associated UserId's in this room.
12901290
///
12911291
/// The vector is ordered by oldest membership to newest.
1292-
fn active_matrix_rtc_memberships(&self) -> Vec<(OwnedUserId, &Membership)> {
1292+
fn active_matrix_rtc_memberships(&self) -> Vec<(OwnedUserId, MembershipData<'_>)> {
12931293
let mut v = self
12941294
.base_info
12951295
.rtc_member
@@ -1304,7 +1304,7 @@ impl RoomInfo {
13041304
})
13051305
.flatten()
13061306
.collect::<Vec<_>>();
1307-
v.sort_by_key(|(_, m)| m.created_ts);
1307+
v.sort_by_key(|(_, m)| m.created_ts());
13081308
v
13091309
}
13101310

@@ -1313,7 +1313,7 @@ impl RoomInfo {
13131313
/// returns Memberships with application "m.call" and scope "m.room".
13141314
///
13151315
/// The vector is ordered by oldest membership user to newest.
1316-
fn active_room_call_memberships(&self) -> Vec<(OwnedUserId, &Membership)> {
1316+
fn active_room_call_memberships(&self) -> Vec<(OwnedUserId, MembershipData<'_>)> {
13171317
self.active_matrix_rtc_memberships()
13181318
.into_iter()
13191319
.filter(|(_user_id, m)| m.is_room_call())
@@ -1485,8 +1485,9 @@ mod tests {
14851485
api::client::sync::sync_events::v3::RoomSummary as RumaSummary,
14861486
events::{
14871487
call::member::{
1488-
Application, CallApplicationContent, CallMemberEventContent, Focus, LivekitFocus,
1489-
Membership, MembershipInit, OriginalSyncCallMemberEvent,
1488+
Application, CallApplicationContent, CallMemberEventContent, Focus,
1489+
LegacyMembershipData, LegacyMembershipDataInit, LivekitFocus,
1490+
OriginalSyncCallMemberEvent,
14901491
},
14911492
room::{
14921493
canonical_alias::RoomCanonicalAliasEventContent,
@@ -2341,11 +2342,11 @@ mod tests {
23412342
}
23422343

23432344
fn call_member_state_event(
2344-
memberships: Vec<Membership>,
2345+
memberships: Vec<LegacyMembershipData>,
23452346
ev_id: &str,
23462347
user_id: &UserId,
23472348
) -> AnySyncStateEvent {
2348-
let content = CallMemberEventContent::new(memberships);
2349+
let content = CallMemberEventContent::new_legacy(memberships);
23492350

23502351
AnySyncStateEvent::CallMember(SyncStateEvent::Original(OriginalSyncCallMemberEvent {
23512352
content,
@@ -2363,7 +2364,7 @@ mod tests {
23632364
device_id: &str,
23642365
membership_id: &str,
23652366
minutes_ago: u32,
2366-
) -> Membership {
2367+
) -> LegacyMembershipData {
23672368
let application = Application::Call(CallApplicationContent::new(
23682369
"my_call_id_1".to_owned(),
23692370
ruma::events::call::member::CallScope::Room,
@@ -2374,7 +2375,7 @@ mod tests {
23742375
))];
23752376

23762377
assign!(
2377-
Membership::from(MembershipInit {
2378+
LegacyMembershipData::from(LegacyMembershipDataInit {
23782379
application,
23792380
device_id: device_id.to_owned(),
23802381
expires: Duration::from_millis(3_600_000),

crates/matrix-sdk-base/src/sliding_sync.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -713,7 +713,7 @@ fn process_room_properties(room_data: &v4::SlidingSyncRoom, room_info: &mut Room
713713
if let Some(heroes) = &room_data.heroes {
714714
// Filter out all the heroes which don't have a user id or name.
715715
room_info.update_heroes(
716-
heroes.iter().filter_map(|hero| hero.user_id.as_ref()).cloned().collect(),
716+
heroes.iter().map(|hero| &hero.user_id).cloned().collect(),
717717
heroes.iter().filter_map(|hero| hero.name.as_ref()).cloned().collect(),
718718
);
719719
}
@@ -1351,12 +1351,10 @@ mod tests {
13511351
// in `heroes`)
13521352
let mut room = v4::SlidingSyncRoom::new();
13531353
room.heroes = Some(vec![
1354-
assign!(v4::SlidingSyncRoomHero::default(), {
1355-
user_id: Some(gordon),
1354+
assign!(v4::SlidingSyncRoomHero::new(gordon), {
13561355
name: Some("Gordon".to_owned()),
13571356
}),
1358-
assign!(v4::SlidingSyncRoomHero::default(), {
1359-
user_id: Some(alice),
1357+
assign!(v4::SlidingSyncRoomHero::new(alice), {
13601358
name: Some("Alice".to_owned()),
13611359
}),
13621360
]);

0 commit comments

Comments
 (0)