feat(WidgetDriver): Send state from state sync and not from timeline to widget #4254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
force-pushed
the
toger5/widget-driver-state-after
branch
from
ca4df5f to
2380af6
Compare
toger5
changed the base branch from
toger5/widget-driver-matrix-api-errors
to
main
toger5
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4254 +/- ##
==========================================
+ Coverage 84.87% 84.90% +0.03%
==========================================
Files 274 274
Lines 29712 29719 +7
==========================================
+ Hits 25218 25233 +15
+ Misses 4494 4486 -8 ☔ View full report in Codecov by Sentry. |
stefanceriu
requested changes
Nov 14, 2024
Co-authored-by: Stefan Ceriu <[email protected]> Signed-off-by: Timo <[email protected]>
Co-authored-by: Stefan Ceriu <[email protected]> Signed-off-by: Timo <[email protected]>
|
@stefanceriu @bnjbvr, I asked this in one of the room but it does not hurt to ask for double confirmation that this comment is actually what is happening: |
|
Looks like that to me, yes: |
|
Confirmed with @bnjbvr that this is indeed correct, will go ahead and merge it 👍 |
raphael-chevallier
pushed a commit
to tchapgouv/matrix-rust-sdk
that referenced
this pull request
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the source of messages send to the widget. Instead of using:
let handle = self.room.add_event_handler(move |raw: Raw<AnySyncTimelineEvent>| {})which listens to all events form the timeline section of the sync, we use two listeners for state and message like:
let handle = self.room.add_event_handler(move |raw: Raw<AnySyncStateEvent>| {})And
let handle = self.room.add_event_handler(move |raw: Raw<AnySyncMessageLikeEvent>| {})AnySyncStateEventshould only get events from the state block of the SSS response.and
AnySyncMessageLikeEventall the message like events from the timeline block.This makes the behaviour equivalent to: element-hq/element-web#28422
Signed-off-by: