Skip to content

Implement the redecryption logic in the event cache #5746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Implement the redecryption logic in the event cache #5746

wants to merge 28 commits into from

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Oct 3, 2025 •
edited
Loading

This is very much a WIP PR. Eventually it will get split into different smaller PRs.

Things that still need to be addressed:

  • Don't load all events for a certain room when attempting to redecrypt events.
  • Decide what to do when the room key stream has lagged.
  • Handle the room key withheld stream as well.
  • Connect the UTD hook to the new redecryptor.
  • Port the timeline redecryption tests.
  • Completely remove the timeline redecryption logic.

poljar added 24 commits September 25, 2025 10:31
@poljar
chore(sqlite): Don't log the room ID twice when saving events
7167d6f
@poljar
feat: Add a method to get the event type of a TimelineEventKind
68b570b
@poljar
refactor(sqlite): Save the event type of an event in the SQLite event…
48cca6c 
… cache
@poljar
feat: Allow events to be fetched by event type
72fe304
@poljar
chore: Fix a comment
22fe54d
@poljar
chore: Make a Note a NOTE
40720c9
@poljar
feat(event cache): Add a method to access the linked chunk mutably
dfeedfb
@poljar
feat: Create the redecryptor thing
e938469
@poljar
WIP
f3e04d3
@poljar
fixup redecryptor
503fa64
@poljar
feat(event_cache): Add the RedecryptorCtx concept
f6770a3
@poljar
fix: Emit event cache updates from the redecryptor
912a499
@poljar
chore: Get rid of the RedecryptorCtx
59d3724 
Doesn't really give us much as we'd like to mock everything for proper
testing anyways.
@poljar
enable the redecryptor in the event cache
e56db05
@poljar
test: Allow to specify the timeout for assert_recv_with_timeout
e5848d9
@poljar
test(event cache): Add a test to show that the redecryptor works
9f16685
@poljar
fixup: Move common methods out of the redecryptor into the cache
4ad7693
@poljar
fixup Make the redecryptor return Self
0566061
@poljar
fixup create a redecryptor in event cache
8d8d588
@poljar
fixup redecryptor
e2ab634
@poljar
Rejigger things so we can relisten to the room key stream
a62fea4
@poljar
refactor: Remove the decryption logic from the timeline
e4bf600
@poljar
fixup redecryptor
f70dbc5
@poljar
doc(event cache): Document the redecryptor
2cfd85f
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 3, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5746 will degrade performances by 82.61%

Comparing poljar/event-cache/redecryptor (54f3b5f) with main (588d604)

Summary

❌ 6 regressions
✅ 44 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ Event cache find_event_relations[SQLite][10 events, #no filter] 1.2 ms 1.9 ms -40.33%
❌ Event cache find_event_relations[SQLite][10 events, edits filter] 1.2 ms 2 ms -41.25%
❌ Event cache find_event_relations[SQLite][100 events, #no filter] 7.9 ms 17.4 ms -54.82%
❌ Event cache find_event_relations[SQLite][100 events, edits filter] 8.4 ms 17.9 ms -53.31%
❌ Event cache find_event_relations[SQLite][1000 events, #no filter] 76.2 ms 438.4 ms -82.61%
❌ Event cache find_event_relations[SQLite][1000 events, edits filter] 80.9 ms 447.8 ms -81.94%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@poljar