Skip to content

Conversation

@Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 27, 2025

Exposes the is_space flag to FFI in the NotificationRoomInfo, so that a client can tell through a notification if the room that generated it, is a space or not.

@Velin92 Velin92 requested a review from a team as a code owner November 27, 2025 12:39
@Velin92 Velin92 requested review from andybalaam and removed request for a team November 27, 2025 12:39
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please just add a changelog entry about this.

@Velin92 Velin92 requested a review from poljar November 27, 2025 12:54
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 27, 2025

CodSpeed Performance Report

Merging #5907 will not alter performance

Comparing mauroromito/add_is_space_in_notification_room_info (cac0fdc) with main (ab98028)

Summary

✅ 50 untouched

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.66%. Comparing base (24d7518) to head (cac0fdc).
⚠️ Report is 12 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5907   +/-   ##
=======================================
  Coverage   88.65%   88.66%           
=======================================
  Files         362      362           
  Lines      104365   104366    +1     
  Branches   104365   104366    +1     
=======================================
+ Hits        92530    92538    +8     
+ Misses       7506     7499    -7     
  Partials     4329     4329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92
Copy link
Member Author

Velin92 commented Nov 27, 2025

@poljar added the changelog

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the trouble, just one minor issue remains.

@Velin92 Velin92 requested a review from poljar December 2, 2025 09:18
@poljar poljar enabled auto-merge (squash) December 2, 2025 09:22
@poljar poljar merged commit 9f02dcd into main Dec 2, 2025
52 checks passed
@poljar poljar deleted the mauroromito/add_is_space_in_notification_room_info branch December 2, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants