-
Notifications
You must be signed in to change notification settings - Fork 358
ffi(bindings): added is_space to the NotificationRoomInfo
#5907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffi(bindings): added is_space to the NotificationRoomInfo
#5907
Conversation
poljar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please just add a changelog entry about this.
CodSpeed Performance ReportMerging #5907 will not alter performanceComparing Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5907 +/- ##
=======================================
Coverage 88.65% 88.66%
=======================================
Files 362 362
Lines 104365 104366 +1
Branches 104365 104366 +1
=======================================
+ Hits 92530 92538 +8
+ Misses 7506 7499 -7
Partials 4329 4329 ☔ View full report in Codecov by Sentry. |
|
@poljar added the changelog |
poljar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the trouble, just one minor issue remains.
Exposes the
is_spaceflag to FFI in theNotificationRoomInfo, so that a client can tell through a notification if the room that generated it, is a space or not.