refactor(sdk): Put ruma-federation-api dependency behind a feature #5912
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5912 +/- ##
==========================================
- Coverage 88.66% 88.65% -0.01%
==========================================
Files 363 363
Lines 104579 104579
Branches 104579 104579
==========================================
- Hits 92726 92718 -8
- Misses 7505 7513 +8
Partials 4348 4348 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5912 will not alter performanceComparing Summary
|
In theory clients shouldn't make requests to the server-server API. A way to work around it for this specific case would be to implement MSC4383. In the meantime, clients that don't want to use `Client::server_vendor_info()` won't have to build the extra dependencies added by ruma-federation-api. The feature is enabled for the bindings, so it isn't a breaking change for matrix-sdk-ffi. Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
force-pushed
the
federation-api-feature
branch
from
e324e77 to
c3acd0d
Compare
Hywan
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory clients shouldn't make requests to the server-server API. A way to work around it for this specific case would be to implement MSC4383.
In the meantime, clients that don't want to use
Client::server_vendor_info()won't have to build the extra dependencies added by ruma-federation-api.The feature is enabled for the bindings, so it isn't a breaking change for matrix-sdk-ffi.
An alternative way to avoid the extra dependencies would be to implement the endpoint in the SDK directly, since the extra dependencies of ruma-federation-api are not necessary for this endpoint. See also the discussion at https://matrix.to/#/!2Z7UlDlK4gFTCIiy2kotE0pyXM2qNp7228PZr9b87Y0/$oEV-B5fPMBgVg3JOR1Qy83DFWVyEcidfdGB0yeE0t8U?via=matrix.org&via=element.io&via=ahouansou.cz.