Skip to content

Commit 902444c

Browse files
uhoregrichvdh
andauthored
Apply suggestions from code review
Co-authored-by: Richard van der Hoff <[email protected]>
1 parent efebba6 commit 902444c

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

api/client-server/cross_signing.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,16 +52,16 @@ paths:
5252
- $ref: definitions/cross_signing_key.yaml
5353
self_signing_key:
5454
description: |-
55-
Optional. The user\'s self-signing key. Must be signed with
56-
the accompanied master, or by the user\'s most recently
55+
Optional. The user\'s self-signing key. Must be signed by
56+
the accompanying master key, or by the user\'s most recently
5757
uploaded master key if no master key is included in the
5858
request.
5959
allOf:
6060
- $ref: definitions/cross_signing_key.yaml
6161
user_signing_key:
6262
description: |-
63-
Optional. The user\'s user-signing key. Must be signed with
64-
the accompanied master, or by the user\'s most recently
63+
Optional. The user\'s user-signing key. Must be signed by
64+
the accompanying master key, or by the user\'s most recently
6565
uploaded master key if no master key is included in the
6666
request.
6767
allOf:

specification/modules/end_to_end_encryption.rst

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -754,18 +754,18 @@ Cross-signing
754754
~~~~~~~~~~~~~
755755

756756
Rather than requiring Alice to verify each of Bob's devices with each of her
757-
own devices and vice versa, the cross-signing feature allows users sign their
757+
own devices and vice versa, the cross-signing feature allows users to sign their
758758
device keys such that Alice and Bob only need to verify once. With
759759
cross-signing, each user has a set of cross-signing keys that are used to sign
760760
their own device keys and other users' keys, and can be used to trust device
761761
keys that were not verified directly.
762762

763-
Each user has three ed25519 keys pairs for cross-signing:
763+
Each user has three ed25519 key pairs for cross-signing:
764764

765765
* a master key (MSK) that serves as the user's identity in cross-signing and signs
766766
their other cross-signing keys;
767767
* a user-signing key (USK) -- only visible to the user that it belongs to --
768-
that signs other users' master keys, and
768+
that signs other users' master keys; and
769769
* a self-signing key (SSK) that signs the user's own device keys.
770770

771771
The master key may also be used to sign other items such as the backup key. The
@@ -863,9 +863,11 @@ A user's master key could allow an attacker to impersonate that user to other
863863
users, or other users to that user. Thus clients must ensure that the private
864864
part of the master key is treated securely. If clients do not have a secure
865865
means of storing the master key (such as a secret storage system provided by
866-
the operating system), then clients must not store the private part. If a user
867-
changes their master key, clients of users that they communicate with must
868-
notify their users about the change.
866+
the operating system), then clients must not store the private part.
867+
868+
If a user's client sees that any other user has changed their master key, that
869+
client must notify the user about the change before allowing communication
870+
between the users to continue.
869871

870872
A user's user-signing and self-signing keys are intended to be easily
871873
replaceable if they are compromised by re-issuing a new key signed by the

0 commit comments

Comments
 (0)