Skip to content

Commit fb091fe

Browse files
turt2liveuhoregpenn5anoadragon453
authored
Apply suggestions from code review
Co-authored-by: Hubert Chathi <[email protected]> Co-authored-by: penn5 <[email protected]> Co-authored-by: Andrew Morgan <[email protected]>
1 parent f9a5b34 commit fb091fe

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

proposals/2778-appservice-login.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ need a way to generate devices for their users so that they can participate in E
55
do so, this proposal suggests implementing an appservice extension to the
66
[`POST /login` endpoint](https://matrix.org/docs/spec/client_server/r0.6.0#post-matrix-client-r0-login).
77

8-
Appservice users do not usually need to login as they do not need their own access token, and do not
8+
Appservice users do not usually need to log in as they do not need their own access token, and do not
99
traditionally need a "device". However, E2E encryption demands that at least one user in a room has a
1010
Matrix device which means bridge users need to be able to generate a device on demand. In the past,
1111
bridge developers have used the bridge bot's device for all bridge users in the room, but this causes
@@ -44,13 +44,13 @@ The response body should be unchanged from the existing `/login` specification.
4444
If one of the following conditions are true:
4545

4646
- The access token is not provided
47-
- The access token does not correspond to a appservice
47+
- The access token does not correspond to an appservice
4848
- Or the user has not previously been registered
4949

5050
Then the servers MUST reject with HTTP 403, with an `errcode` of `"M_FORBIDDEN"`.
5151

52-
If the access token DOES correspond to a appservice but the user is not inside its namespace,
53-
then the `errcode` should be `"M_EXCLUSIVE"`.
52+
If the access token DOES correspond to an appservice but the user is not inside its namespace,
53+
then the `errcode` must be `"M_EXCLUSIVE"`.
5454

5555
Homeservers should ignore the `access_token` parameter if a type other than
5656
`m.login.application_service` has been provided.
@@ -109,10 +109,10 @@ Furthermore, the ability to generate access tokens for real users who registered
109109
## Security considerations
110110

111111
Appservices could use this new functionality to generate devices for any userId that are within its namespace e.g. setting the
112-
user namespace regex to `@.*:example.com` would allow appservice to control anyone on the homeserver. While this sounds scary, in practise
112+
user namespace regex to `@.*:example.com` would allow appservice to control anyone on the homeserver. While this sounds scary, in practice
113113
this is not a problem because:
114114

115-
- Appservice namespaces are mainained by the homeserver admin. If the namespace were to change, then it's reasonable
115+
- Appservice namespaces are maintained by the homeserver admin. If the namespace were to change, then it's reasonable
116116
to assume that the server admin is aware. There is no defense mechanism to stop a malicious server admin from creating new
117117
devices for a given user's account as they could also do so by simply modifying the database.
118118

0 commit comments

Comments
 (0)