Clarify the meaning of a read_events action without a state_key #4288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently MSC2762 is ambiguous as to whether the absence of a state_key in a read_events action means that both state events and message-like events should be returned, or just message-like events. We should clarify this behavior, and I for one find it difficult to imagine a real use case that would benefit from the ability to read both state events and message-like events of a single event type as part of the same request, so I propose we limit the response to just message-like events in this case. This aligns the behavior with what Element Web did prior to the introduction of the update_state action.
|
Discussed in a VoIP team meeting, and we all seem aligned on this being a reasonable behavior. |
|
matrix.org has a voip team? |
|
Element has and a part of the ppl advancing and working on the matrix.org widget spec are part of it. (but this is off-topic here. Its better to use an appropriate matrix room for these kind of questions.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not an MSC but rather an update to MSC2762. I'm using this PR to give our team a chance to discuss the update.
Currently MSC2762 is ambiguous as to whether the absence of a
state_keyin aread_eventsaction means that both state events and message-like events should be returned, or just message-like events. We should clarify this behavior, and I for one find it difficult to imagine a real use case that would benefit from the ability to read both state events and message-like events of a single event type as part of the same request, so I propose we limit the response to just message-like events in this case. This aligns the behavior with what Element Web did prior to the introduction of theupdate_stateaction.