Skip to content

Conversation

@robintown
Copy link
Member

@robintown robintown added X-Blocked Cannot be merged due to external dependencies and removed X-Blocked Cannot be merged due to external dependencies labels Mar 4, 2025
@robintown robintown requested review from fkwp, hughns and toger5 March 5, 2025 17:45
@robintown
Copy link
Member Author

In draft until we get branch protection turned on in this repo, so that a status check can actually block you from merging

@robintown robintown marked this pull request as draft March 5, 2025 22:27
@robintown robintown force-pushed the robin/prevent-blocked branch from 9fbb934 to 27c9aed Compare March 18, 2025 19:19
@robintown
Copy link
Member Author

Actually, it turns out you need to list the specific status checks that should protect a branch, so we should merge this before enabling branch protection.

@robintown robintown marked this pull request as ready for review March 18, 2025 19:20
@sonarqubecloud
Copy link

@robintown robintown merged commit 4428315 into master Mar 19, 2025
4 checks passed
@robintown robintown deleted the robin/prevent-blocked branch March 19, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants