matrix.to urls for aliases don't need a via param (#348)

Author: jesopo

src/utils.ts

@@ -226,7 +226,8 @@ export async function replaceRoomIdsWithPills(mjolnir: Mjolnir, text: string, ro
         const regexRoomId = new RegExp(escapeRegex(roomId), "g");
         content.body = content.body.replace(regexRoomId, alias);
         if (content.formatted_body) {
-            content.formatted_body = content.formatted_body.replace(regexRoomId, `<a href="${Permalinks.forRoom(alias, viaServers)}">${alias}</a>`);
+            const permalink = Permalinks.forRoom(alias, alias !== roomId ? [] : viaServers);
+            content.formatted_body = content.formatted_body.replace(regexRoomId, `<a href="${permalink}">${alias}</a>`);
         }
     }
 

test/integration/utilsTest.ts

@@ -20,13 +20,13 @@ describe("Test: utils", function() {
         const out = await replaceRoomIdsWithPills(
             this.mjolnir,
             `it's fun here in ${this.mjolnir.managementRoomId}`,
-            new Set([this.mjolnir.managementRoomId])
+            new Set([this.mjolnir.managementRoomId, "!myfaketestid:example.com"])
         );
 
         const ourHomeserver = new UserID(await this.mjolnir.client.getUserId()).domain;
         assert.equal(
             out.formatted_body,
-            `it's fun here in <a href="https://matrix.to/#/${managementRoomAlias}?via=${ourHomeserver}">${managementRoomAlias}</a>`
+            `it's fun here in <a href="https://matrix.to/#/${managementRoomAlias}">${managementRoomAlias}</a>`
         );
     });
 });