fix: return error body with 412 response

hughns · hughns · commit ecc80372cad9 · 2024-04-23T10:23:42.000+01:00
diff --git a/src/index.ts b/src/index.ts
@@ -118,7 +118,7 @@ app.put("/:id", sessionCors, (req, res) => {
             return res.status(400).json({ "errcode": "M_MISSING_PARAM", "error": "Missing If-Match header" });
         } else if (ifMatch !== rv.etag) {
             rv.setHeaders(res);
-            return res.send(412).json({ "errcode": "M_UNKNOWN", "org.matrix.msc4108.errcode": "M_CONCURRENT_WRITE", "error": "Rendezvous has been modified" });
+            return res.status(412).json({ "errcode": "M_UNKNOWN", "org.matrix.msc4108.errcode": "M_CONCURRENT_WRITE", "error": "Rendezvous has been modified" });
         }
 
         rv.update(req.body, contentType);

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ app.put("/:id", sessionCors, (req, res) => {`
`118`	`118`	`return res.status(400).json({ "errcode": "M_MISSING_PARAM", "error": "Missing If-Match header" });`
`119`	`119`	`} else if (ifMatch !== rv.etag) {`
`120`	`120`	`rv.setHeaders(res);`
`121`		`- return res.send(412).json({ "errcode": "M_UNKNOWN", "org.matrix.msc4108.errcode": "M_CONCURRENT_WRITE", "error": "Rendezvous has been modified" });`
	`121`	`+ return res.status(412).json({ "errcode": "M_UNKNOWN", "org.matrix.msc4108.errcode": "M_CONCURRENT_WRITE", "error": "Rendezvous has been modified" });`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`rv.update(req.body, contentType);`