Skip to content
This repository was archived by the owner on Nov 25, 2022. It is now read-only.

Commit e1ae0fb

Browse files
authored
Clean up linter configs for Element Web (#138)
* Add style linter to element-web (was missing) * Remove commented linter that never existed * Add an expansion section to the existing linters that were missing it
1 parent cc6d084 commit e1ae0fb

File tree

2 files changed

+17
-10
lines changed

2 files changed

+17
-10
lines changed

element-web/pipeline.yaml

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ steps:
44
- "echo '--- Fetching Dependencies'"
55
- "./scripts/fetch-develop.deps.sh --depth 1"
66
- "yarn install"
7+
- "echo '+++ Lint'"
78
- "yarn lint:js"
89
plugins:
910
- docker#v3.0.1:
@@ -13,16 +14,6 @@ steps:
1314
propagate-environment: true
1415
mount-buildkite-agent: false
1516

16-
# This layer doesn't have a TypeScript linter. This comment is to remind TravisR to fix that.
17-
# - label: ":eslint: TS Lint"
18-
# command:
19-
# - "echo '--- Install js-sdk'"
20-
# - "./scripts/ci/install-deps.sh"
21-
# - "yarn lint:ts"
22-
# plugins:
23-
# - docker#v3.0.1:
24-
# image: "node:14-buster"
25-
2617
- label: ":eslint: Types Lint"
2718
command:
2819
- "echo '--- Fetching Dependencies'"
@@ -38,6 +29,21 @@ steps:
3829
propagate-environment: true
3930
mount-buildkite-agent: false
4031

32+
- label: ":stylelint: Style Lint"
33+
command:
34+
- "echo '--- Fetching Dependencies'"
35+
- "./scripts/fetch-develop.deps.sh --depth 1"
36+
- "yarn install"
37+
- "echo '+++ Lint'"
38+
- "yarn lint:types"
39+
plugins:
40+
- docker#v3.0.1:
41+
image: "node:14-buster"
42+
# This allows the test script to see what branch it's testing and check
43+
# out the equivalent dependency branches, if they exist
44+
propagate-environment: true
45+
mount-buildkite-agent: false
46+
4147
- label: ":hammer_and_wrench: Build"
4248
agents:
4349
# We use a medium sized instance instead of the normal small ones because

matrix-react-sdk/pipeline.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ steps:
2929
command:
3030
- "echo '--- Install'"
3131
- "yarn install --ignore-scripts"
32+
- "echo '+++ Lint'"
3233
- "yarn lint:style"
3334
plugins:
3435
- docker#v3.0.1:

0 commit comments

Comments
 (0)