Skip to content

Commit e2b591a

Browse files
committed
Fix pull_request comment and justify reasoning
1 parent 6d4ce64 commit e2b591a

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

.github/workflows/docker.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,11 @@ on:
77
tags: ["v*"]
88
branches: [ main ]
99
workflow_dispatch:
10-
# Run on pull requests to test docker build.
11-
# We explicitly do not push on pull requests (the job below is ended early).
10+
# Run on pull requests so that the docker build is tested.
11+
#
12+
# We explicitly do not push on pull requests (see `if` conditionals and `push`
13+
# attribute of `docker/build-push-action` below). This prevents us from filling
14+
# up the container registries with in-progress builds.
1215
#
1316
# note: secrets will not be populated on pull requests from external authors.
1417
pull_request:

0 commit comments

Comments
 (0)