Fix Clippy warnings with Rust 1.86.0

Signed-off-by: Jan Alexander Steffens (heftig) <[email protected]>

Author: heftig

compressor_integration_tests/src/lib.rs

@@ -98,7 +98,7 @@ pub fn empty_database() {
 /// Safely escape the strings in sql queries
 struct PGEscape<'a>(pub &'a str);
 
-impl<'a> fmt::Display for PGEscape<'a> {
+impl fmt::Display for PGEscape<'_> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         let mut delim = Cow::from("$$");
         while self.0.contains(&delim as &str) {

src/database.rs

@@ -192,7 +192,7 @@ fn load_level_heads(client: &mut Client, level_info: &[Level]) -> BTreeMap<i64,
 /// specific room within a certain range. These are appended onto the provided
 /// map.
 ///
-/// - Fetches the first [group] rows with group id after [min]
+/// - Fetches the first `[group]` rows with group id after `[min]`
 /// - Recursively searches for missing predecessors and adds those
 ///
 /// Returns with the state_group map and the id of the last group that was used
@@ -206,7 +206,6 @@ fn load_level_heads(client: &mut Client, level_info: &[Level]) -> BTreeMap<i64,
 ///                             also requires groups_to_compress to be specified
 /// * 'max_group_found'     -   The last group to get from the database before stopping
 /// * 'state_group_map'     -   The map to populate with the entries from the database
-
 fn load_map_from_db(
     client: &mut Client,
     room_id: &str,
@@ -326,7 +325,7 @@ fn find_max_group(
 /// Fetch the entries in state_groups_state and immediate predecessors for
 /// a specific room.
 ///
-/// - Fetches first [groups_to_compress] rows with group id higher than min
+/// - Fetches first `[groups_to_compress]` rows with group id higher than min
 /// - Stores the group id, predecessor id and deltas into a map
 /// - returns map and maximum row that was considered
 ///
@@ -467,7 +466,7 @@ fn get_missing_from_db(
 /// Helper function that escapes the wrapped text when writing SQL
 pub struct PGEscape<'a>(pub &'a str);
 
-impl<'a> fmt::Display for PGEscape<'a> {
+impl fmt::Display for PGEscape<'_> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         let mut delim = Cow::from("$$");
         while self.0.contains(&delim as &str) {

src/graphing.rs

@@ -1,5 +1,4 @@
-use std::collections::BTreeMap;
-use std::{fs::File, io::Write};
+use std::{collections::BTreeMap, fs::File, io::Write};
 
 use super::StateGroupEntry;
 

src/lib.rs

@@ -12,6 +12,9 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// FIXME: Rewrite argument lists to not trigger this lint.
+#![allow(clippy::doc_overindented_list_items)]
+
 //! This is a tool that attempts to further compress state maps within a
 //! Synapse instance's database. Specifically, it aims to reduce the number of
 //! rows that a given room takes up in the `state_groups_state` table.
@@ -304,7 +307,6 @@ impl Config {
 /// # Arguments
 ///
 /// * `config: Config` - A Config struct that controlls the run
-
 pub fn run(mut config: Config) {
     // First we need to get the current state groups
     info!("Fetching state from DB for room '{}'...", config.room_id);

src/main.rs

@@ -21,8 +21,7 @@
 static GLOBAL: tikv_jemallocator::Jemalloc = tikv_jemallocator::Jemalloc;
 
 use log::LevelFilter;
-use std::env;
-use std::io::Write;
+use std::{env, io::Write};
 
 use synapse_compress_state as comp_state;
 

synapse_auto_compressor/src/lib.rs

@@ -1,3 +1,6 @@
+// FIXME: Rewrite argument lists to not trigger this lint.
+#![allow(clippy::doc_overindented_list_items)]
+
 //! This is a tool that uses the synapse_compress_state library to
 //! reduce the size of the synapse state_groups_state table in a postgres
 //! database.