Merge pull request #385 from nisbet-hubbard/patch-2

kegsay · web-flow · commit 49c92260b8d9 · 2024-01-08T10:26:03.000Z
Fix unix socket permissions
diff --git a/v3.go b/v3.go
@@ -248,8 +248,9 @@ func unixSocketListener(bindAddr string) net.Listener {
 	if err != nil {
 		logger.Fatal().Err(err).Msg("failed to serve unix socket")
 	}
-	// TODO: safe default for now (rwxr-xr-x), could be extracted as env variable if needed
-	err = os.Chmod(bindAddr, 0755)
+	// least permissions and work out of box (-w--w--w-); could be extracted as
+	// env variable if needed
+	err = os.Chmod(bindAddr, 0222)
 	if err != nil {
 		logger.Fatal().Err(err).Msg("failed to set unix socket permissions")
 	}

Original file line number	Diff line number	Diff line change
`@@ -248,8 +248,9 @@ func unixSocketListener(bindAddr string) net.Listener {`
`248`	`248`	`if err != nil {`
`249`	`249`	`logger.Fatal().Err(err).Msg("failed to serve unix socket")`
`250`	`250`	`}`
`251`		`- // TODO: safe default for now (rwxr-xr-x), could be extracted as env variable if needed`
`252`		`- err = os.Chmod(bindAddr, 0755)`
	`251`	`+ // least permissions and work out of box (-w--w--w-); could be extracted as`
	`252`	`+ // env variable if needed`
	`253`	`+ err = os.Chmod(bindAddr, 0222)`
`253`	`254`	`if err != nil {`
`254`	`255`	`logger.Fatal().Err(err).Msg("failed to set unix socket permissions")`
`255`	`256`	`}`