Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit a03ed5e

Browse files
authored
Fix issue causing sending presence to ASes to fail (due to incomplete type annotations) (#10944)
1 parent e32b9f4 commit a03ed5e

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

changelog.d/10944.bugfix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix a bug introduced in v1.44.0rc1 which prevented sending presence events to application services.

synapse/handlers/presence.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
from synapse.api.constants import EventTypes, Membership, PresenceState
5353
from synapse.api.errors import SynapseError
5454
from synapse.api.presence import UserPresenceState
55+
from synapse.appservice import ApplicationService
5556
from synapse.events.presence_router import PresenceRouter
5657
from synapse.logging.context import run_in_background
5758
from synapse.logging.utils import log_function
@@ -1521,10 +1522,11 @@ async def get_new_events(
15211522
user: UserID,
15221523
from_key: Optional[int],
15231524
limit: Optional[int] = None,
1524-
room_ids: Optional[List[str]] = None,
1525+
room_ids: Optional[Collection[str]] = None,
15251526
is_guest: bool = False,
15261527
explicit_room_id: Optional[str] = None,
15271528
include_offline: bool = True,
1529+
service: Optional[ApplicationService] = None,
15281530
) -> Tuple[List[UserPresenceState], int]:
15291531
# The process for getting presence events are:
15301532
# 1. Get the rooms the user is in.

0 commit comments

Comments
 (0)