Make all rooms noisy by default (#60)

Author: MatMaul

changelog.d/60.misc

@@ -0,0 +1 @@
+Make all rooms noisy by default.

synapse/push/baserules.py

@@ -335,7 +335,11 @@ def make_base_prepend_rules(kind, modified_base_rules):
                 "_id": "_message",
             }
         ],
-        "actions": ["notify", {"set_tweak": "highlight", "value": False}],
+        "actions": [
+            "notify",
+            {"set_tweak": "sound", "value": "default"},
+            {"set_tweak": "highlight", "value": False},
+        ],
     },
     # XXX: this is going to fire for events which aren't m.room.messages
     # but are encrypted (e.g. m.call.*)...
@@ -349,7 +353,11 @@ def make_base_prepend_rules(kind, modified_base_rules):
                 "_id": "_encrypted",
             }
         ],
-        "actions": ["notify", {"set_tweak": "highlight", "value": False}],
+        "actions": [
+            "notify",
+            {"set_tweak": "sound", "value": "default"},
+            {"set_tweak": "highlight", "value": False},
+        ],
     },
 ]
 

tests/push/test_http.py

@@ -346,8 +346,8 @@ def test_sends_high_priority_for_one_to_one_only(self):
         self.assertEqual(len(self.push_attempts), 2)
         self.assertEqual(self.push_attempts[1][1], "example.com")
 
-        # check that this is low-priority
-        self.assertEqual(self.push_attempts[1][2]["notification"]["prio"], "low")
+        # check that this is high-priority
+        self.assertEqual(self.push_attempts[1][2]["notification"]["prio"], "high")
 
     def test_sends_high_priority_for_mention(self):
         """
@@ -418,8 +418,8 @@ def test_sends_high_priority_for_mention(self):
         self.assertEqual(len(self.push_attempts), 2)
         self.assertEqual(self.push_attempts[1][1], "example.com")
 
-        # check that this is low-priority
-        self.assertEqual(self.push_attempts[1][2]["notification"]["prio"], "low")
+        # check that this is high-priority
+        self.assertEqual(self.push_attempts[1][2]["notification"]["prio"], "high")
 
     def test_sends_high_priority_for_atroom(self):
         """
@@ -497,5 +497,5 @@ def test_sends_high_priority_for_atroom(self):
         self.assertEqual(len(self.push_attempts), 2)
         self.assertEqual(self.push_attempts[1][1], "example.com")
 
-        # check that this is low-priority
-        self.assertEqual(self.push_attempts[1][2]["notification"]["prio"], "low")
+        # check that this is high-priority
+        self.assertEqual(self.push_attempts[1][2]["notification"]["prio"], "high")