Pin attrs to <21.1.0 (#9937)

erikjohnston · web-flow · commit 24f07a83e604 · 2021-05-06T14:06:06.000+01:00
Fixes #9936
diff --git a/changelog.d/9937.bugfix b/changelog.d/9937.bugfix
@@ -0,0 +1 @@
+Fix bug where `/sync` would break if using the latest version of `attrs` dependency, by pinning to a previous version.
diff --git a/synapse/python_dependencies.py b/synapse/python_dependencies.py
@@ -78,7 +78,8 @@
     # we use attr.validators.deep_iterable, which arrived in 19.1.0 (Note:
     # Fedora 31 only has 19.1, so if we want to upgrade we should wait until 33
     # is out in November.)
-    "attrs>=19.1.0",
+    # Note: 21.1.0 broke `/sync`, see #9936
+    "attrs>=19.1.0,<21.1.0",
     "netaddr>=0.7.18",
     "Jinja2>=2.9",
     "bleach>=1.4.3",

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix bug where `/sync` would break if using the latest version of `attrs` dependency, by pinning to a previous version.