Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 4e68857

Browse files
committed
Update comment about notifying cache changes on workers when changing rejection status
1 parent 39c5fd5 commit 4e68857

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

synapse/storage/databases/main/events_worker.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2391,6 +2391,9 @@ def mark_event_rejected_txn(
23912391
23922392
This can happen, for example, when resyncing state during a faster join.
23932393
2394+
It is the caller's responsibility to ensure that other workers are
2395+
sent a notification so that they call `_invalidate_local_get_event_cache()`.
2396+
23942397
Args:
23952398
txn:
23962399
event_id: ID of event to update
@@ -2429,14 +2432,3 @@ def mark_event_rejected_txn(
24292432
)
24302433

24312434
self.invalidate_get_event_cache_after_txn(txn, event_id)
2432-
2433-
# TODO(faster_joins): invalidate the cache on workers. Ideally we'd just
2434-
# call '_send_invalidation_to_replication', but we actually need the other
2435-
# end to call _invalidate_local_get_event_cache() rather than (just)
2436-
# _get_event_cache.invalidate().
2437-
#
2438-
# One solution might be to (somehow) get the workers to call
2439-
# _invalidate_caches_for_event() (though that will invalidate more than
2440-
# strictly necessary).
2441-
#
2442-
# https://github.com/matrix-org/synapse/issues/12994

0 commit comments

Comments
 (0)