Add missing dependency on importlib_metadata (#12384)

David Robertson · web-flow · commit 573cd0f92f78 · 2022-04-05T18:25:56.000Z
diff --git a/changelog.d/12384.misc b/changelog.d/12384.misc
@@ -0,0 +1 @@
+Make missing `importlib_metadata` dependency explicit.
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -167,6 +167,9 @@ ijson = ">=3.1.4"
 matrix-common = "~=1.1.0"
 # We need packaging.requirements.Requirement, added in 16.1.
 packaging = ">=16.1"
+# At the time of writing, we only use functions from the version `importlib.metadata`
+# which shipped in Python 3.8. This corresponds to version 1.4 of the backport.
+importlib_metadata = { version = ">=1.4", python = "<3.8" }
 
 
 # Optional Dependencies
diff --git a/synapse/python_dependencies.py b/synapse/python_dependencies.py
@@ -89,6 +89,9 @@
     "matrix-common~=1.1.0",
     # We need packaging.requirements.Requirement, added in 16.1.
     "packaging>=16.1",
+    # At the time of writing, we only use functions from the version `importlib.metadata`
+    # which shipped in Python 3.8. This corresponds to version 1.4 of the backport.
+    "importlib_metadata>=1.4",
 ]
 
 CONDITIONAL_REQUIREMENTS = {

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Make missing `importlib_metadata` dependency explicit.
Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,9 @@`
`89`	`89`	`"matrix-common~=1.1.0",`
`90`	`90`	`# We need packaging.requirements.Requirement, added in 16.1.`
`91`	`91`	`"packaging>=16.1",`
	`92`	+ # At the time of writing, we only use functions from the version `importlib.metadata`
	`93`	`+ # which shipped in Python 3.8. This corresponds to version 1.4 of the backport.`
	`94`	`+ "importlib_metadata>=1.4",`
`92`	`95`	`]`
`93`	`96`
`94`	`97`	`CONDITIONAL_REQUIREMENTS = {`