Remove the unspecced room_id field in the /hierarchy response. (#13365)

clokep · web-flow · commit 57d334a13d98 · 2022-07-26T08:02:34.000-04:00
The `room_id` field represented the parent space for each room
and was made redundant by changes in the API shape where the
`children_state` is now nested underneath each `room`.

The room ID of each child is in the `state_key` field and is still
available.
diff --git a/changelog.d/13365.bugfix b/changelog.d/13365.bugfix
@@ -0,0 +1 @@
+Fix a bug introduced in Synapse v1.41.0 where the `/hierarchy` API returned non-standard information (a `room_id` field under each entry in `children_state`).
diff --git a/synapse/handlers/room_summary.py b/synapse/handlers/room_summary.py
@@ -452,7 +452,6 @@ async def _summarize_local_room(
                 "type": e.type,
                 "state_key": e.state_key,
                 "content": e.content,
-                "room_id": e.room_id,
                 "sender": e.sender,
                 "origin_server_ts": e.origin_server_ts,
             }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix a bug introduced in Synapse v1.41.0 where the `/hierarchy` API returned non-standard information (a `room_id` field under each entry in `children_state`).
Original file line number	Diff line number	Diff line change
`@@ -452,7 +452,6 @@ async def _summarize_local_room(`
`452`	`452`	`"type": e.type,`
`453`	`453`	`"state_key": e.state_key,`
`454`	`454`	`"content": e.content,`
`455`		`- "room_id": e.room_id,`
`456`	`455`	`"sender": e.sender,`
`457`	`456`	`"origin_server_ts": e.origin_server_ts,`
`458`	`457`	`}`