Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 5edd91c

Browse files
committed
Fix incompatibility with tox 2.5
Apparently on tox 2.5, `usedevelop` overrides `skip_install`, so we end up trying to install the full dependencies even for the `-old` environment.
1 parent e2b8a90 commit 5edd91c

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

changelog.d/9769.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix incompatibility with `tox` 2.5.

tox.ini

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,8 @@ usedevelop=true
104104
# A test suite for the oldest supported versions of Python libraries, to catch
105105
# any uses of APIs not available in them.
106106
[testenv:py35-old]
107-
skip_install=True
107+
skip_install = true
108+
usedevelop = false
108109
deps =
109110
# Old automat version for Twisted
110111
Automat == 0.3.0
@@ -136,7 +137,8 @@ commands =
136137
python -m synmark {posargs:}
137138

138139
[testenv:packaging]
139-
skip_install=True
140+
skip_install = true
141+
usedevelop = false
140142
deps =
141143
check-manifest
142144
commands =
@@ -154,7 +156,8 @@ extras = lint
154156
commands = isort -c --df --sp setup.cfg {[base]lint_targets}
155157

156158
[testenv:check-newsfragment]
157-
skip_install = True
159+
skip_install = true
160+
usedevelop = false
158161
deps = towncrier>=18.6.0rc1
159162
commands =
160163
python -m towncrier.check --compare-with=origin/develop
@@ -163,7 +166,8 @@ commands =
163166
commands = {toxinidir}/scripts-dev/generate_sample_config --check
164167

165168
[testenv:combine]
166-
skip_install = True
169+
skip_install = true
170+
usedevelop = false
167171
deps =
168172
coverage
169173
pip>=10 ; python_version >= '3.6'
@@ -173,14 +177,16 @@ commands=
173177
coverage report
174178

175179
[testenv:cov-erase]
176-
skip_install = True
180+
skip_install = true
181+
usedevelop = false
177182
deps =
178183
coverage
179184
commands=
180185
coverage erase
181186

182187
[testenv:cov-html]
183-
skip_install = True
188+
skip_install = true
189+
usedevelop = false
184190
deps =
185191
coverage
186192
commands=

0 commit comments

Comments
 (0)