Rotate notifications more frequently (#13096)

erikjohnston · web-flow · commit 5ef05c70c30e · 2022-06-17T10:58:00.000Z
diff --git a/changelog.d/13096.misc b/changelog.d/13096.misc
@@ -0,0 +1 @@
+Reduce DB usage of `/sync` when a large number of unread messages have recently been sent in a room.
diff --git a/synapse/storage/databases/main/event_push_actions.py b/synapse/storage/databases/main/event_push_actions.py
@@ -148,7 +148,7 @@ def __init__(
         self._doing_notif_rotation = False
         if hs.config.worker.run_background_tasks:
             self._rotate_notif_loop = self._clock.looping_call(
-                self._rotate_notifs, 30 * 60 * 1000
+                self._rotate_notifs, 30 * 1000
             )
 
         self.db_pool.updates.register_background_index_update(

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Reduce DB usage of `/sync` when a large number of unread messages have recently been sent in a room.
Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ def __init__(`
`148`	`148`	`self._doing_notif_rotation = False`
`149`	`149`	`if hs.config.worker.run_background_tasks:`
`150`	`150`	`self._rotate_notif_loop = self._clock.looping_call(`
`151`		`- self._rotate_notifs, 30 * 60 * 1000`
	`151`	`+ self._rotate_notifs, 30 * 1000`
`152`	`152`	`)`
`153`	`153`
`154`	`154`	`self.db_pool.updates.register_background_index_update(`