Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 9f902da

Browse files
committed
Explain why we want to set the state there
1 parent aa0a109 commit 9f902da

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

synapse/rest/client/room_batch.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,11 @@ async def on_POST(
196196
),
197197
base_insertion_event_dict,
198198
prev_event_ids=base_insertion_event_dict.get("prev_events"),
199-
# TODO: Is state_event_ids necessary here?
199+
# Also set the explicit state here because we want to resolve
200+
# any `state_events_at_start` here too. It's not strictly
201+
# necessary to accomplish anything but if someone asks for the
202+
# state at this point, we probably want to show them the
203+
# historical state that was part of this batch.
200204
state_event_ids=state_event_ids,
201205
historical=True,
202206
depth=inherited_depth,

0 commit comments

Comments
 (0)