Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit d2fd7f7

Browse files
authored
Fix a stale comment in get_room_version_id_txn. (#12969)
1 parent 9dc3293 commit d2fd7f7

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

changelog.d/12969.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix an inaccurate comment.

synapse/storage/databases/main/state.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -127,13 +127,8 @@ def get_room_version_id_txn(self, txn: LoggingTransaction, room_id: str) -> str:
127127
NotFoundError: if the room is unknown
128128
"""
129129

130-
# First we try looking up room version from the database, but for old
131-
# rooms we might not have added the room version to it yet so we fall
132-
# back to previous behaviour and look in current state events.
133-
#
134130
# We really should have an entry in the rooms table for every room we
135-
# care about, but let's be a bit paranoid (at least while the background
136-
# update is happening) to avoid breaking existing rooms.
131+
# care about, but let's be a bit paranoid.
137132
room_version = self.db_pool.simple_select_one_onecol_txn(
138133
txn,
139134
table="rooms",

0 commit comments

Comments
 (0)